tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

parse the string to be converted to group codes.

Browse Source 
Two fixes.
1. parse the group code by using Convert::raw2url() as it creates duplicate records if the group code is given in upper case letters, spaces etc. 
2. assigning to the $_cache_groupByCode has to be really done in the if condition rather than out of it.
This commit is contained in:
Nivanka Fonseka 2015-12-02 10:01:25 +05:30
parent 1bc7297c8f
commit 411f168f00
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
security/MemberCsvBulkLoader.php
View File

@ -40,6 +40,7 @@ class MemberCsvBulkLoader extends CsvBulkLoader {
if(isset($record['Groups']) && $record['Groups']) { if(isset($record['Groups']) && $record['Groups']) {
$groupCodes = explode(',', $record['Groups']); $groupCodes = explode(',', $record['Groups']);
foreach($groupCodes as $groupCode) { foreach($groupCodes as $groupCode) {
$groupCode = Convert::raw2url($groupCode);
if(!isset($_cache_groupByCode[$groupCode])) { if(!isset($_cache_groupByCode[$groupCode])) {
$group = Group::get()->filter('Code', $groupCode)->first(); $group = Group::get()->filter('Code', $groupCode)->first();
if(!$group) { if(!$group) {
@ -49,10 +50,10 @@ class MemberCsvBulkLoader extends CsvBulkLoader {
$group->write(); $group->write();
} }
$member->Groups()->add($group); $member->Groups()->add($group);
}
$_cache_groupByCode[$groupCode] = $group; $_cache_groupByCode[$groupCode] = $group;
} }
} }
}
$member->destroy(); $member->destroy();
unset($member); unset($member);