Minor cleanup of DirectorTest

tests/php/Control/DirectorTest.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace SilverStripe\Control\Tests;
 
 use SilverStripe\Control\Cookie_Backend;
@@ -193,24 +194,26 @@ class DirectorTest extends SapphireTest
 
     /**
      * Tests that {@link Director::is_absolute()} works under different environment types
+     * @dataProvider provideAbsolutePaths
      */
-    public function testIsAbsolute()
+    public function testIsAbsolute($path, $result)
     {
-        $expected = array (
+        $this->assertEquals($result, Director::is_absolute($path));
-            'C:/something' => true,
-            'd:\\'         => true,
-            'e/'           => false,
-            's:/directory' => true,
-            '/var/www'     => true,
-            '\\Something'  => true,
-            'something/c:' => false,
-            'folder'       => false,
-            'a/c:/'        => false
-        );
-
-        foreach ($expected as $path => $result) {
-            $this->assertEquals(Director::is_absolute($path), $result, "Test result for $path");
     }
+
+    public function provideAbsolutePaths()
+    {
+        return [
+            ['C:/something', true],
+            ['d:\\', true],
+            ['e/', false],
+            ['s:/directory', true],
+            ['/var/www', true],
+            ['\\Something', true],
+            ['something/c:', false],
+            ['folder', false],
+            ['a/c:/', false],
+        ];
     }
 
     public function testIsAbsoluteUrl()