From 090f07d9788076fb4f11129b3e31f51f929c1230 Mon Sep 17 00:00:00 2001 From: Mateusz Uzdowski Date: Mon, 12 Aug 2013 09:30:31 +1200 Subject: [PATCH 1/2] BUG Apply HTML5 required attributes when fields are required. --- forms/FormField.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/forms/FormField.php b/forms/FormField.php index 87b73e63c..7608d607e 100644 --- a/forms/FormField.php +++ b/forms/FormField.php @@ -360,6 +360,11 @@ class FormField extends RequestHandler { 'disabled' => $this->isDisabled(), ); + if ($this->Required()) { + $attrs['required'] = 'required'; + $attrs['aria-required'] = 'true'; + } + return array_merge($attrs, $this->attributes); } From 085d2e62cb07f29602106de9faa4f50f498e0b8c Mon Sep 17 00:00:00 2001 From: Mateusz Uzdowski Date: Fri, 9 Aug 2013 12:59:52 +1200 Subject: [PATCH 2/2] BUG MemberLoginForm fields should be tagged as required. --- security/MemberLoginForm.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/security/MemberLoginForm.php b/security/MemberLoginForm.php index cb584539c..9e6795339 100644 --- a/security/MemberLoginForm.php +++ b/security/MemberLoginForm.php @@ -94,6 +94,8 @@ class MemberLoginForm extends LoginForm { parent::__construct($controller, $name, $fields, $actions); + $this->setValidator(new RequiredFields('Email', 'Password')); + // Focus on the email input when the page is loaded Requirements::customScript(<<