tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Consistently instantiate HasManyList and ManyManyList using create()

Browse Source
This commit is contained in:
Sean Harvey 2013-05-21 18:10:46 +12:00
parent 13e632d053
commit 34b9952e9d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
model/DataObject.php
View File

@ -1433,7 +1433,7 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
$joinField = $this->getRemoteJoinField($componentName, 'has_many'); $joinField = $this->getRemoteJoinField($componentName, 'has_many');
$result = new HasManyList($componentClass, $joinField); $result = HasManyList::create($componentClass, $joinField);
if($this->model) $result->setDataModel($this->model); if($this->model) $result->setDataModel($this->model);
$result = $result->forForeignID($this->ID); $result = $result->forForeignID($this->ID);
@ -1557,7 +1557,7 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
return $this->unsavedRelations[$componentName]; return $this->unsavedRelations[$componentName];
} }
$result = Injector::inst()->create('ManyManyList', $componentClass, $table, $componentField, $parentField, $result = ManyManyList::create($componentClass, $table, $componentField, $parentField,
$this->many_many_extraFields($componentName)); $this->many_many_extraFields($componentName));
if($this->model) $result->setDataModel($this->model); if($this->model) $result->setDataModel($this->model);