tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-01 13:48:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #5231 from kinglozzer/sqlselect-docs

Browse Source 
Fix code docs for SQLSelect::count()
This commit is contained in:
Damian Mooyman 2016-03-30 14:12:11 +13:00
commit 2cfd3ab997
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
model/queries/SQLSelect.php
View File

@ -568,14 +568,12 @@ class SQLSelect extends SQLConditionalExpression {
/**
* Return the number of rows in this query if the limit were removed. Useful in paged data sets.
*
* @todo Respect HAVING and GROUPBY, which can affect the result-count
* Return the number of rows in this query, respecting limit and offset.
*
* @param string $column Quoted, escaped column name
* @return int
*/
public function count( $column = null) {
public function count($column = null) {
// we can't clear the select if we're relying on its output by a HAVING clause
if(!empty($this->having)) {
$records = $this->execute();