tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Consistently quote DataObject::$default_sort

Browse Source 
Strictly speaking, no longer required since we auto-quote simple
field names in DataQuery now, but since the majority of sorts in core is
already quoted we should stay consistent.
This commit is contained in:
Ingo Schommer 2013-04-02 13:33:14 +02:00
parent 5a8a067ae8
commit 2bc273e2a8
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/forms/gridfield/GridFieldDetailFormTest.php
View File

@ -242,7 +242,7 @@ class GridFieldDetailFormTest_Person extends DataObject implements TestOnly {
) )
); );
private static $default_sort = 'FirstName'; private static $default_sort = '"FirstName"';
public function getCMSFields() { public function getCMSFields() {
$fields = parent::getCMSFields(); $fields = parent::getCMSFields();
@ -266,7 +266,7 @@ class GridFieldDetailFormTest_PeopleGroup extends DataObject implements TestOnly
'People' => 'GridFieldDetailFormTest_Person' 'People' => 'GridFieldDetailFormTest_Person'
); );
private static $default_sort = 'Name'; private static $default_sort = '"Name"';
public function getCMSFields() { public function getCMSFields() {
$fields = parent::getCMSFields(); $fields = parent::getCMSFields();
@ -290,7 +290,7 @@ class GridFieldDetailFormTest_Category extends DataObject implements TestOnly {
'People' => 'GridFieldDetailFormTest_Person' 'People' => 'GridFieldDetailFormTest_Person'
); );
private static $default_sort = 'Name'; private static $default_sort = '"Name"';
public function getCMSFields() { public function getCMSFields() {
$fields = parent::getCMSFields(); $fields = parent::getCMSFields();

2
tests/model/DataObjectTest.php
View File

@ -1161,7 +1161,7 @@ class DataObjectTest_Team extends DataObject implements TestOnly {
) )
); );
private static $default_sort = "Title"; private static $default_sort = '"Title"';
public function MyTitle() { public function MyTitle() {
return 'Team ' . $this->Title; return 'Team ' . $this->Title;