From 2939e3355455886b79df46356df95c62014f2827 Mon Sep 17 00:00:00 2001 From: Normann Lou Date: Thu, 29 Jan 2009 05:17:10 +0000 Subject: [PATCH] ENHANCEMENT: Ticket 2756: Newsletter performance problem, run out of memory. git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@70956 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- forms/ComplexTableField.php | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/forms/ComplexTableField.php b/forms/ComplexTableField.php index 0321c11a6..f3e8cff5c 100755 --- a/forms/ComplexTableField.php +++ b/forms/ComplexTableField.php @@ -755,8 +755,9 @@ class ComplexTableField_ItemRequest extends RequestHandler { if(!isset($_REQUEST['ctf']['start']) || !is_numeric($_REQUEST['ctf']['start']) || $_REQUEST['ctf']['start'] == 0) { return null; } - - $item = $this->unpagedSourceItems->First(); + + // We never use $item afterwards in the function, where we have it here? disable it! + //$item = $this->unpagedSourceItems->First(); $start = 0; return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}"); } @@ -765,8 +766,9 @@ class ComplexTableField_ItemRequest extends RequestHandler { if(!isset($_REQUEST['ctf']['start']) || !is_numeric($_REQUEST['ctf']['start']) || $_REQUEST['ctf']['start'] == $this->totalCount-1) { return null; } - - $item = $this->unpagedSourceItems->Last(); + + // We never use $item afterwards in the function, where we have it here? disable it! + // $item = $this->unpagedSourceItems->Last(); $start = $this->totalCount - 1; return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}"); } @@ -776,7 +778,8 @@ class ComplexTableField_ItemRequest extends RequestHandler { return null; } - $item = $this->unpagedSourceItems->getIterator()->getOffset($_REQUEST['ctf']['start'] + 1); + // We never use $item afterwards in the function, where we have it here? disable it! + //$item = $this->unpagedSourceItems->getIterator()->getOffset($_REQUEST['ctf']['start'] + 1); $start = $_REQUEST['ctf']['start'] + 1; return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}"); @@ -787,7 +790,8 @@ class ComplexTableField_ItemRequest extends RequestHandler { return null; } - $item = $this->unpagedSourceItems->getIterator()->getOffset($_REQUEST['ctf']['start'] - 1); + // We never use $item afterwards in the function, where we have it here? disable it! + //$item = $this->unpagedSourceItems->getIterator()->getOffset($_REQUEST['ctf']['start'] - 1); $start = $_REQUEST['ctf']['start'] - 1; return Controller::join_links($this->Link(), "$this->methodName?ctf[start]={$start}");