tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Document contributing committers

Browse Source 
See https://github.com/silverstripe/silverstripe-framework/pull/8021#issuecomment-386423095
This commit is contained in:
Ingo Schommer 2018-05-07 20:07:13 +12:00
parent 53938f3bde
commit 27ec9724cb
1 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
docs/en/05_Contributing/09_Core_committers.md
View File

@ -1,7 +1,7 @@
# Core Committers # Core Committers
The core committers team is reviewed approximately annually, new members are added based on quality contributions to SilverStipe code and outstanding community participation. The Core Committers team is reviewed approximately annually, new members are added based on quality contributions to SilverStipe code and outstanding community participation.
## Core committer team ## Core Committer team
* [Aaron Carlino](https://github.com/unclecheese/) * [Aaron Carlino](https://github.com/unclecheese/)
* [Chris Joe](https://github.com/flamerohr/) * [Chris Joe](https://github.com/flamerohr/)
@ -15,9 +15,9 @@ The core committers team is reviewed approximately annually, new members are add
* [Stevie Mayhew](https://github.com/stevie-mayhew/) * [Stevie Mayhew](https://github.com/stevie-mayhew/)
* [Will Rossiter](https://github.com/wilr/) * [Will Rossiter](https://github.com/wilr/)
## House rules for the core committer team ## House rules for the Core Committer team
The "core committers" consist of everybody with write permissions to our codebase. The "Core Committers" consist of everybody with write permissions to our codebase.
With great power comes great responsibility, so we have agreed on certain expectations: With great power comes great responsibility, so we have agreed on certain expectations:
* Be friendly, encouraging and constructive towards other community members * Be friendly, encouraging and constructive towards other community members
@ -28,9 +28,21 @@ With great power comes great responsibility, so we have agreed on certain expect
* Ensure contributions have appropriate [test coverage](../developer_guides/testing), are documented, and pass our [coding conventions](/getting_started/coding_conventions) * Ensure contributions have appropriate [test coverage](../developer_guides/testing), are documented, and pass our [coding conventions](/getting_started/coding_conventions)
* Keep the codebase "releasable" at all times (check our [release process](release_process)) * Keep the codebase "releasable" at all times (check our [release process](release_process))
* API changes and non-trivial features should not be merged into release branches. * API changes and non-trivial features should not be merged into release branches.
* API changes on master should not be merged until they have the buy-in of at least two core committers (or better, through the [core mailing list](https://groups.google.com/forum/#!forum/silverstripe-dev)) * API changes on master should not be merged until they have the buy-in of at least two Core Committers (or better, through the [core mailing list](https://groups.google.com/forum/#!forum/silverstripe-dev))
* Be inclusive. Ensure a wide range of SilverStripe developers can obtain an understanding of your code and docs, and you're not the only one who can maintain it. * Be inclusive. Ensure a wide range of SilverStripe developers can obtain an understanding of your code and docs, and you're not the only one who can maintain it.
* Avoid `git push --force`, and be careful with your git remotes (no accidental pushes) * Avoid `git push --force`, and be careful with your git remotes (no accidental pushes)
* Use your own forks to create feature branches * Use your own forks to create feature branches
* We release using the standard process. See the [Making a SilverStripe Core Release](making_a_silverstripe_core_release) * We release using the standard process. See the [Making a SilverStripe Core Release](making_a_silverstripe_core_release)
## Contributing Committers
Beyond the group of Core Committers, there can be individuals which
focus on core development work - typically sponsored through full-time product development roles by SilverStripe Ltd.
These Contributing Committers require write access to core repositories to maintain their pace,
often working alongside Core Committers. They are guided by additional rules:
* Contributing Committers have write access to core repositories in order to work effectively with Github issues. They are expected to use those permissions with good judgement regarding merges of pull requests.
* Complex or impactful changes need to be reviewed and approved by one or more Core Committers. This includes any additions, removals or changes to commonly used APIs. If that's not possible in the team, ping `@silverstripe/core-team` to get other Core Committers involved.
* For these complex or impactful changes, Core Committers should be given 1-2 working days to review. Ideally at this point, the API has already been agreed on through issue comments outlining the planned work (see [RFC Process](request_for_comment]).
* More straightforward changes (e.g. documentation, styling) or areas which require quite specialised expertise (e.g. React) that's less available through most Core Committers can be approved or merged by team members who aren't Core Committers
* Self-merges should be avoided, but are preferable to having work go stale or forcing other team members to waste time by context switching into a complex review (e.g. because the original reviewer went on leave). Any self-merge should be accompanied by a comment why this couldn't be handled in another way, and a (preferably written) approval from another team member.