tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

NEW: Deprecated PDO in favour of native drivers

Browse Source 
https://github.com/silverstripe/silverstripe-framework/issues/8598
This commit is contained in:
Sam Minnee 2019-06-11 16:17:30 +12:00
parent 731646f49d
commit 27ace03273
3 changed files with 22 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
_register_database.php
View File

@ -4,24 +4,6 @@
use SilverStripe\Dev\Install\DatabaseAdapterRegistry; use SilverStripe\Dev\Install\DatabaseAdapterRegistry;
use SilverStripe\Dev\Install\MySQLDatabaseConfigurationHelper; use SilverStripe\Dev\Install\MySQLDatabaseConfigurationHelper;
// Register MySQL PDO as a database adapter (listed as first option in Dev/Install/config-form.html)
DatabaseAdapterRegistry::register(
array(
/** @skipUpgrade */
'class' => 'MySQLPDODatabase',
'module' => 'framework',
'title' => 'MySQL 5.0+ (using PDO)',
'helperPath' => __DIR__ . '/src/Dev/Install/MySQLDatabaseConfigurationHelper.php',
'helperClass' => MySQLDatabaseConfigurationHelper::class,
'supported' => (class_exists('PDO') && in_array('mysql', PDO::getAvailableDrivers())),
'missingExtensionText' =>
'Either the <a href="http://www.php.net/manual/en/book.pdo.php">PDO Extension</a> or
the <a href="http://www.php.net/manual/en/ref.pdo-mysql.php">MySQL PDO Driver</a>
are unavailable. Please install or enable these and refresh this page.'
)
);
// Register MySQLi as a database adapter (listed as second option in Dev/Install/config-form.html) // Register MySQLi as a database adapter (listed as second option in Dev/Install/config-form.html)
DatabaseAdapterRegistry::register( DatabaseAdapterRegistry::register(
array( array(
@ -37,3 +19,20 @@ DatabaseAdapterRegistry::register(
PHP extension is not available. Please install or enable it and refresh this page.' PHP extension is not available. Please install or enable it and refresh this page.'
) )
); );
// Register MySQL PDO as a database adapter (listed as first option in Dev/Install/config-form.html)
DatabaseAdapterRegistry::register(
array(
/** @skipUpgrade */
'class' => 'MySQLPDODatabase',
'module' => 'framework',
'title' => 'MySQL 5.0+ (using PDO) - <b>not recommended</b>',
'helperPath' => __DIR__ . '/src/Dev/Install/MySQLDatabaseConfigurationHelper.php',
'helperClass' => MySQLDatabaseConfigurationHelper::class,
'supported' => (class_exists('PDO') && in_array('mysql', PDO::getAvailableDrivers())),
'missingExtensionText' =>
'Either the <a href="http://www.php.net/manual/en/book.pdo.php">PDO Extension</a> or
the <a href="http://www.php.net/manual/en/ref.pdo-mysql.php">MySQL PDO Driver</a>
are unavailable. Please install or enable these and refresh this page.'
)
);

2
src/Dev/Install/InstallConfig.php
View File

@ -20,8 +20,8 @@ class InstallConfig
* @var array * @var array
*/ */
protected $preferredDatabases = [ protected $preferredDatabases = [
'MySQLPDODatabase',
'MySQLDatabase', 'MySQLDatabase',
'MySQLPDODatabase',
]; ];
public function __construct($basePath = null) public function __construct($basePath = null)

4
src/ORM/Connect/PDOConnector.php
View File

@ -3,6 +3,7 @@
namespace SilverStripe\ORM\Connect; namespace SilverStripe\ORM\Connect;
use SilverStripe\Core\Config\Config; use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\Deprecation;
use PDO; use PDO;
use PDOStatement; use PDOStatement;
use InvalidArgumentException; use InvalidArgumentException;
@ -135,6 +136,9 @@ class PDOConnector extends DBConnector implements TransactionManager
public function connect($parameters, $selectDB = false) public function connect($parameters, $selectDB = false)
{ {
Deprecation::notice('4.5', 'Use native database drivers in favour of PDO. '
. 'https://github.com/silverstripe/silverstripe-framework/issues/8598');
$this->flushStatements(); $this->flushStatements();
// Note that we don't select the database here until explicitly // Note that we don't select the database here until explicitly