From 26a0e915536f067c5c5429ffa5224f3cff37b886 Mon Sep 17 00:00:00 2001 From: Damian Mooyman Date: Wed, 30 Jul 2014 11:07:01 +1200 Subject: [PATCH] API SS_Filterable, SS_Limitable and SS_Sortable now explicitly extend SS_List --- docs/en/changelogs/3.2.0.md | 1 + model/Filterable.php | 4 ++-- model/Limitable.php | 4 ++-- model/Sortable.php | 6 +++--- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/docs/en/changelogs/3.2.0.md b/docs/en/changelogs/3.2.0.md index d45a2a154..45decc2a7 100644 --- a/docs/en/changelogs/3.2.0.md +++ b/docs/en/changelogs/3.2.0.md @@ -11,6 +11,7 @@ * HtmlEditorField no longer substitutes `
` for indented text * ClassInfo::dataClassesFor now returns classes which should have tables, regardless of whether those tables actually exist. + * SS_Filterable, SS_Limitable and SS_Sortable now explicitly extend SS_List ### CMS diff --git a/model/Filterable.php b/model/Filterable.php index d534ad96e..cb5a3c6f7 100644 --- a/model/Filterable.php +++ b/model/Filterable.php @@ -10,7 +10,7 @@ * @package framework * @subpackage model */ -interface SS_Filterable { +interface SS_Filterable extends SS_List { /** * Returns TRUE if the list can be filtered by a given field expression. @@ -19,7 +19,7 @@ interface SS_Filterable { * @return bool */ public function canFilterBy($by); - + /** * Return a new instance of this list that only includes items with these charactaristics * diff --git a/model/Limitable.php b/model/Limitable.php index b2489887b..30d4f3ca9 100644 --- a/model/Limitable.php +++ b/model/Limitable.php @@ -10,13 +10,13 @@ * @package framework * @subpackage model */ -interface SS_Limitable { +interface SS_Limitable extends SS_List { /** * Returns a new instance of this list where no more than $limit records are included. * If $offset is specified, then that many records at the beginning of the list will be skipped. * This matches the behaviour of the SQL LIMIT clause. - * + * * @return SS_Limitable */ public function limit($limit, $offset = 0); diff --git a/model/Sortable.php b/model/Sortable.php index 98b8881b3..a70364c28 100644 --- a/model/Sortable.php +++ b/model/Sortable.php @@ -10,7 +10,7 @@ * @package framework * @subpackage model */ -interface SS_Sortable { +interface SS_Sortable extends SS_List { /** * Returns TRUE if the list can be sorted by a field. @@ -31,8 +31,8 @@ interface SS_Sortable { * @example $list = $list->sort(array('Name'=>'ASC,'Age'=>'DESC')); */ public function sort(); - - + + /** * Return a new instance of this list based on reversing the current sort. *