ENHANCEMENT SSF-53 : remove literal field for explanation text of Parent dropdown, use a right title for it, instead

This commit is contained in:
Normann Lou 2012-03-08 10:41:04 +13:00
parent a59637c77c
commit 1de30d5bf2

View File

@ -66,15 +66,11 @@ class Group extends DataObject {
new TabSet("Root", new TabSet("Root",
new Tab('Members', _t('SecurityAdmin.MEMBERS', 'Members'), new Tab('Members', _t('SecurityAdmin.MEMBERS', 'Members'),
new TextField("Title", $this->fieldLabel('Title')), new TextField("Title", $this->fieldLabel('Title')),
Object::create('DropdownField', $parentidfield = Object::create('DropdownField',
'ParentID', 'ParentID',
$this->fieldLabel('Parent'), $this->fieldLabel('Parent'),
DataList::create('Group')->exclude('ID', $this->ID)->map('ID', 'Breadcrumbs') DataList::create('Group')->exclude('ID', $this->ID)->map('ID', 'Breadcrumbs')
)->setEmptyString(' '), )->setEmptyString(' ')
new LiteralField(
'ParentIDDescription',
'<p><em>' . _t('Group.GroupReminder', 'If you choose a parent group, this group will take all it\'s roles') . '</em></p>'
)
), ),
$permissionsTab = new Tab('Permissions', _t('SecurityAdmin.PERMISSIONS', 'Permissions'), $permissionsTab = new Tab('Permissions', _t('SecurityAdmin.PERMISSIONS', 'Permissions'),
@ -89,6 +85,8 @@ class Group extends DataObject {
) )
); );
$parentidfield->setRightTitle('<span class="aligned_right_label">' . _t('Group.GroupReminder', 'If you choose a parent group, this group will take all it\'s roles') . '</span>');
// Filter permissions // Filter permissions
// TODO SecurityAdmin coupling, not easy to get to the form fields through GridFieldPopupForms // TODO SecurityAdmin coupling, not easy to get to the form fields through GridFieldPopupForms
$permissionsField->setHiddenPermissions(SecurityAdmin::$hidden_permissions); $permissionsField->setHiddenPermissions(SecurityAdmin::$hidden_permissions);