From 9660652fbca17870ad2bbd52aec96aff7d8d4a44 Mon Sep 17 00:00:00 2001
From: Nicolaas / Sunny Side Up <github@sunnysideup.co.nz>
Date: Fri, 28 Apr 2023 09:40:12 +1200
Subject: [PATCH] MINOR: faster checking if record exists

Rather than using a loop through each object, we just filter for it in the SQL query.  This is likely to speed up the code and also make it more legible.
---
 src/Security/Member.php | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/Security/Member.php b/src/Security/Member.php
index c6ec8d763..2d388fc1f 100644
--- a/src/Security/Member.php
+++ b/src/Security/Member.php
@@ -924,15 +924,8 @@ class Member extends DataObject
         }
 
         $groupCandidateObjs = ($strict) ? $this->getManyManyComponents("Groups") : $this->Groups();
-        if ($groupCandidateObjs) {
-            foreach ($groupCandidateObjs as $groupCandidateObj) {
-                if ($groupCandidateObj->ID == $groupCheckObj->ID) {
-                    return true;
-                }
-            }
-        }
 
-        return false;
+        return $groupCandidateObjs->filter(['ID' => $groupCheckObj->ID])->exists();
     }
 
     /**