Merge branch '3.5' into 3

docs/en/02_Developer_Guides/03_Forms/03_Form_Templates.md

@@ -14,7 +14,7 @@ can be rendered out using custom templates using `setTemplate`.
 	$field = new TextField(..);
 	$field->setTemplate('MyCustomTextField');
 
-Both `MyCustomTemplate.ss` and `MyCustomTextField.ss` should be located in **mysite/templates/Includes/**
+Both `MyCustomTemplate.ss` and `MyCustomTextField.ss` should be located in **mysite/templates/forms/** or the same directory as the core.
 
 <div class="notice" markdown="1">
 It's recommended to copy the contents of the template you're going to replace and use that as a start. For instance, if

forms/Form.php

@@ -1404,6 +1404,7 @@ class Form extends RequestHandler {
 		if(is_object($data)) $this->record = $data;
 
 		// dont include fields without data
+		/** @var FormField[] $dataFields */
 		$dataFields = $this->Fields()->dataFields();
 		if($dataFields) foreach($dataFields as $field) {
 			$name = $field->getName();
@@ -1436,15 +1437,31 @@ class Form extends RequestHandler {
 					$val = $data[$name];
 				}
 				// If field is in array-notation we need to access nested data
-				else if(strpos($name,'[')) {
+				else if(preg_match_all('/(.*)\[(.*)\]/U', $name, $matches)) {
-					// First encode data using PHP's method of converting nested arrays to form data
+					//discard first match which is just the whole string
-					$flatData = urldecode(http_build_query($data));
+					array_shift($matches);
-					// Then pull the value out from that flattened string
-					preg_match('/' . addcslashes($name,'[]') . '=([^&]*)/', $flatData, $matches);
 
-					if (isset($matches[1])) {
+					$keys = array_pop($matches);
+					$name = array_shift($matches);
+					$name = array_shift($name);
+
+					if (array_key_exists($name, $data)) {
+						$tmpData = &$data[$name];
+						// drill down into the data array looking for the corresponding value
+						foreach ($keys as $arrayKey) {
+							if ($arrayKey !== '') {
+								$tmpData = &$tmpData[$arrayKey];
+							} else {
+								//empty square brackets means new array
+								if (is_array($tmpData)) {
+									$tmpData = array_shift($tmpData);
+								}
+							}
+						}
+						if ($tmpData) {
+							$val = $tmpData;
 							$exists = true;
-						$val = $matches[1];
+						}
 					}
 				}
 			}

tests/forms/FormTest.php

@@ -58,10 +58,10 @@ class FormTest extends FunctionalTest {
 		$form->loadDataFrom($requestData);
 
 		$fields = $form->Fields();
-		$this->assertEquals($fields->fieldByName('key1')->Value(), 'val1');
+		$this->assertEquals('val1', $fields->fieldByName('key1')->Value());
-		$this->assertEquals($fields->fieldByName('namespace[key2]')->Value(), 'val2');
+		$this->assertEquals('val2', $fields->fieldByName('namespace[key2]')->Value());
-		$this->assertEquals($fields->fieldByName('namespace[key3][key4]')->Value(), 'val4');
+		$this->assertEquals('val4', $fields->fieldByName('namespace[key3][key4]')->Value());
-		$this->assertEquals($fields->fieldByName('othernamespace[key5][key6][key7]')->Value(), 'val7');
+		$this->assertEquals('val7', $fields->fieldByName('othernamespace[key5][key6][key7]')->Value());
 	}
 
 	public function testSubmitReadonlyFields() {

tests/forms/HtmlEditorFieldTest.php

@@ -15,6 +15,20 @@ class HtmlEditorFieldTest extends FunctionalTest {
 
 	protected $extraDataObjects = array('HtmlEditorFieldTest_Object');
 
+	public function testCasting() {
+		// Test special characters
+		$inputText = "These are some unicodes: ä, ö, & ü";
+		$field = new HTMLEditorField("Test", "Test");
+		$field->setValue($inputText);
+		$this->assertContains('These are some unicodes: ä, ö, & ü', $field->Field());
+
+		// Test shortcodes
+		$inputText = "Shortcode: [file_link id=4]";
+		$field = new HTMLEditorField("Test", "Test");
+		$field->setValue($inputText);
+		$this->assertContains('Shortcode: [file_link id=4]', $field->Field());
+	}
+
 	public function testBasicSaving() {
 		$obj = new HtmlEditorFieldTest_Object();
 		$editor   = new HtmlEditorField('Content');

tests/forms/TextareaFieldTest.php

@@ -2,6 +2,20 @@
 
 class TextareaFieldTest extends SapphireTest {
 
+	public function testCasting() {
+		// Test special characters
+		$inputText = "These are some unicodes: ä, ö, & ü";
+		$field = new TextareaField("Test", "Test");
+		$field->setValue($inputText);
+		$this->assertContains('These are some unicodes: ä, ö, & ü', $field->Field());
+
+		// Test shortcodes
+		$inputText = "Shortcode: [file_link id=4]";
+		$field = new TextareaField("Test", "Test");
+		$field->setValue($inputText);
+		$this->assertContains('Shortcode: [file_link id=4]', $field->Field());
+	}
+
 	/**
 	 * Quick smoke test to ensure that text with unicodes is being displayed properly in readonly fields.
 	 */