From 199e267bbf8121645922f7f0e5caeeff2a767f6b Mon Sep 17 00:00:00 2001 From: Sam Minnee Date: Sun, 22 Nov 2009 16:26:48 +1300 Subject: [PATCH] MINOR: Don't add 'OFFSET 0' to a query unnecessarily. --- model/Database.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/model/Database.php b/model/Database.php index 0d08f9ac1..72a359b7f 100755 --- a/model/Database.php +++ b/model/Database.php @@ -728,7 +728,7 @@ abstract class SS_Database { if(!array_key_exists('limit',$limit)) user_error('SQLQuery::limit(): Wrong format for $limit', E_USER_ERROR); if(isset($limit['start']) && is_numeric($limit['start']) && isset($limit['limit']) && is_numeric($limit['limit'])) { - $combinedLimit = "$limit[limit] OFFSET $limit[start]"; + $combinedLimit = $limit['start'] ? "$limit[limit] OFFSET $limit[start]" : "$limit[limit]"; } elseif(isset($limit['limit']) && is_numeric($limit['limit'])) { $combinedLimit = (int)$limit['limit']; } else { @@ -740,7 +740,6 @@ abstract class SS_Database { $text .= " LIMIT " . $sqlQuery->limit; } } - return $text; }