From 168a4fe4891460a4563f9fce8b275707be490e4d Mon Sep 17 00:00:00 2001 From: Vinnie Date: Thu, 9 May 2019 09:01:54 +1200 Subject: [PATCH] Update docs for GridField_ActionMenuItem required parameters I found these errors while going through this tutorial, missing ```use use SilverStripe\Forms\GridField\GridField;``` interface GridField_ActionMenuItem required parameters on getTitle() and getGroup() incorrect if statement on getExtraData() - $field is not defined --- .../How_Tos/04_Create_a_GridField_ActionProvider.md | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/en/02_Developer_Guides/03_Forms/How_Tos/04_Create_a_GridField_ActionProvider.md b/docs/en/02_Developer_Guides/03_Forms/How_Tos/04_Create_a_GridField_ActionProvider.md index 33f056048..61148ee8c 100644 --- a/docs/en/02_Developer_Guides/03_Forms/How_Tos/04_Create_a_GridField_ActionProvider.md +++ b/docs/en/02_Developer_Guides/03_Forms/How_Tos/04_Create_a_GridField_ActionProvider.md @@ -22,6 +22,7 @@ below: use SilverStripe\Forms\GridField\GridField_ColumnProvider; use SilverStripe\Forms\GridField\GridField_ActionProvider; use SilverStripe\Forms\GridField\GridField_FormAction; +use SilverStripe\Forms\GridField\GridField; use SilverStripe\Control\Controller; class GridFieldCustomAction implements GridField_ColumnProvider, GridField_ActionProvider @@ -176,20 +177,20 @@ class GridFieldDeleteAction implements GridField_ColumnProvider, GridField_Actio } } - public function getTitle($gridField, $record) + public function getTitle($gridField, $record, $columnName) { return _t(__CLASS__ . '.Delete', "Delete"); } - public function getGroup($gridField, $record) + public function getGroup($gridField, $record, $columnName) { return GridField_ActionMenuItem::DEFAULT_GROUP; } public function getExtraData($gridField, $record, $columnName) { - if ($field) { - return $field->getAttributes(); + if ($gridField) { + return $gridField->getAttributes(); } return null;