tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-04 07:08:34 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: groupby works for SQLite too

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97985 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Andreas Piening 2010-02-02 02:58:18 +00:00 committed by Sam Minnee
parent cce52a59d2
commit 15e98877f5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/model/DataObject.php
View File

@ -2569,7 +2569,7 @@ class DataObject extends ViewableData implements DataObjectInterface, i18nEntity
if($join) { if($join) {
$query->from[] = $join; $query->from[] = $join;
if(DB::getConn() instanceof MySQLDatabase) { if(DB::getConn() instanceof MySQLDatabase || DB::getConn() instanceof SQLite3Database) {
// TODO: This needs to be resolved for all databases // TODO: This needs to be resolved for all databases
$query->groupby[] = reset($query->from) . ".\"ID\""; $query->groupby[] = reset($query->from) . ".\"ID\"";
/* this needs to be fixed - this doesn't work when you add additional fields from other tables into the mix. /* this needs to be fixed - this doesn't work when you add additional fields from other tables into the mix.