From 13b7b4c4e72e8e14e110d0c217d5fc8848c42128 Mon Sep 17 00:00:00 2001 From: Sam Minnee Date: Sat, 4 Oct 2008 04:45:43 +0000 Subject: [PATCH] Added instructions to try and prevent #2901 issues reoccurring git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63636 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- core/control/Controller.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/control/Controller.php b/core/control/Controller.php index 11a9704c8..9dd537253 100644 --- a/core/control/Controller.php +++ b/core/control/Controller.php @@ -49,6 +49,10 @@ class Controller extends RequestHandlingData { /** * Handles HTTP requests. + * + * If you are going to overload handleRequest, make sure that you start the method with $this->pushCurrent() + * and end the method with $this->popCurrent(). Failure to do this will create weird session errors. + * * @param $request The {@link HTTPRequest} object that is responsible for distributing request parsing. */ function handleRequest(HTTPRequest $request) {