diff --git a/forms/CheckboxSetField.php b/forms/CheckboxSetField.php index 55eb8cf2b..f1ef4bbaa 100644 --- a/forms/CheckboxSetField.php +++ b/forms/CheckboxSetField.php @@ -132,11 +132,14 @@ class CheckboxSetField extends OptionsetField { } foreach($source as $value => $item) { + // Ensure $title is cast for template if($item instanceof DataObject) { $value = $item->ID; - $title = $item->Title; - } else { + $title = $item->obj('Title'); + } elseif ($item instanceof DBField) { $title = $item; + } else { + $title = DBField::create_field('Text', $item); } $itemID = $this->ID() . '_' . preg_replace('/[^a-zA-Z0-9]/', '', $value); diff --git a/forms/OptionsetField.php b/forms/OptionsetField.php index fb37c075b..9d9aca57b 100644 --- a/forms/OptionsetField.php +++ b/forms/OptionsetField.php @@ -62,6 +62,11 @@ class OptionsetField extends DropdownField { if($source) { foreach($source as $value => $title) { + // Ensure $title is safely cast + if ( !($title instanceof DBField) ) { + $title = DBField::create_field('Text', $title); + } + $itemID = $this->ID() . '_' . preg_replace('/[^a-zA-Z0-9]/', '', $value); $odd = ($odd + 1) % 2; $extraClass = $odd ? 'odd' : 'even'; diff --git a/templates/forms/CheckboxSetField.ss b/templates/forms/CheckboxSetField.ss index f5210733e..1cf6c1195 100644 --- a/templates/forms/CheckboxSetField.ss +++ b/templates/forms/CheckboxSetField.ss @@ -2,9 +2,9 @@ <% if $Options.Count %> <% loop $Options %>
  • - checked="checked"<% end_if %><% if $isDisabled %> disabled="disabled"<% end_if %> /> + checked="checked"<% end_if %><% if $isDisabled %> disabled="disabled"<% end_if %> /> -
  • + <% end_loop %> <% else %>
  • No options available
  • diff --git a/templates/forms/OptionsetField.ss b/templates/forms/OptionsetField.ss index aa3f4cc5e..e01272857 100644 --- a/templates/forms/OptionsetField.ss +++ b/templates/forms/OptionsetField.ss @@ -1,7 +1,7 @@