tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

BUGFIX: removed name attribute from label fields since this is invalid html. Ticket: #4887. PATCH via tobych

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@97013 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Will Rossiter 2010-01-15 02:23:03 +00:00 committed by Sam Minnee
parent 5ce693ce40
commit 1125de1b99
2 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
forms/LabelField.php
View File

@ -37,8 +37,7 @@ class LabelField extends DatalessField {
function Field() { function Field() {
$attributes = array( $attributes = array(
'class' => $this->extraClass(), 'class' => $this->extraClass(),
'id' => $this->id(), 'id' => $this->id()
'name' => $this->Name(),
); );
return $this->createTag( return $this->createTag(
'label', 'label',

13
tests/fieldtypes/LabelFieldTest.php Normal file
View File

@ -0,0 +1,13 @@
<?php
/**
* @package sapphire
* @subpackage tests
*/
class LabelFieldTest extends SapphireTest {
function testFieldHasNoNameAttribute() {
$field = new LabelField('MyName', 'MyTitle');
$this->assertEquals($field->Field(), '<label id="MyName">MyTitle</label>');
}
}