tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #5840 from sminnee/correct-classname-values

Browse Source 
FIX: Remap obsolete ClassName values.
This commit is contained in:
Damian Mooyman 2016-07-26 09:59:50 +12:00 committed by GitHub
commit 0c4d9a90c0
1 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
ORM/DatabaseAdmin.php
View File

@ -37,6 +37,20 @@ class DatabaseAdmin extends Controller {
'import' 'import'
); );
/**
* Obsolete classname values that should be remapped in dev/build
*/
private static $classname_value_remapping = [
'Group' => 'SilverStripe\\Security\\Group',
'LoginAttempt' => 'SilverStripe\\Security\\LoginAttempt',
'Member' => 'SilverStripe\\Security\\Member',
'MemberPassword' => 'SilverStripe\\Security\\MemberPassword',
'Permission' => 'SilverStripe\\Security\\Permission',
'PermissionRole' => 'SilverStripe\\Security\\PermissionRole',
'PermissionRoleCode' => 'SilverStripe\\Security\\PermissionRoleCode',
'RememberLoginHash' => 'SilverStripe\\Security\\RememberLoginHash',
];
protected function init() { protected function init() {
parent::init(); parent::init();
@ -159,7 +173,7 @@ class DatabaseAdmin extends Controller {
public function buildDefaults() { public function buildDefaults() {
$dataClasses = ClassInfo::subclassesFor('SilverStripe\ORM\DataObject'); $dataClasses = ClassInfo::subclassesFor('SilverStripe\ORM\DataObject');
array_shift($dataClasses); array_shift($dataClasses);
foreach($dataClasses as $dataClass){ foreach($dataClasses as $dataClass) {
singleton($dataClass)->requireDefaultRecords(); singleton($dataClass)->requireDefaultRecords();
print "Defaults loaded for $dataClass<br/>"; print "Defaults loaded for $dataClass<br/>";
} }
@ -281,6 +295,19 @@ class DatabaseAdmin extends Controller {
singleton($dataClass)->requireDefaultRecords(); singleton($dataClass)->requireDefaultRecords();
} }
} }
// Remap obsolete class names
$schema = DataObject::getSchema();
foreach ($this->config()->classname_value_remapping as $oldClassName => $newClassName) {
$badRecordCount = $newClassName::get()->filter(["ClassName" => $oldClassName ])->count();
if($badRecordCount > 0) {
if(Director::is_cli()) echo " * Correcting $badRecordCount obsolete classname values for $newClassName\n";
else echo "<li>Correcting $badRecordCount obsolete classname values for $newClassName</li>\n";
$table = $schema->baseDataTable($newClassName);
DB::prepared_query("UPDATE \"$table\" SET \"ClassName\" = ? WHERE \"ClassName\" = ?", [ $newClassName, $oldClassName ]);
}
}
} }
touch(TEMP_FOLDER touch(TEMP_FOLDER
@ -357,3 +384,4 @@ class DatabaseAdmin extends Controller {
} }
} }