From 0b5599e21bdc70e8e7ea965ef01eb6144d527439 Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Thu, 21 Aug 2014 17:30:03 +1200 Subject: [PATCH] Remove suppression operator on session_start() This was originally added to stop PHP on Windows complaining that it couldn't garbage collect old sessions, but that was for an old version of PHP years ago and doesn't seem to be an issue any longer. We really shouldn't be suppressing this. If session_start() threw a warning that it couldn't write to the filesystem, then we wouldn't know about it at all. --- control/Session.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/control/Session.php b/control/Session.php index 71886726e..37fb3e65b 100644 --- a/control/Session.php +++ b/control/Session.php @@ -376,10 +376,8 @@ class Session { // seperate (less secure) session for non-HTTPS requests if($secure) session_name('SECSESSID'); - // @ is to supress win32 warnings/notices when session wasn't cleaned up properly - // There's nothing we can do about this, because it's an operating system function! if($sid) session_id($sid); - @session_start(); + session_start(); $this->data = isset($_SESSION) ? $_SESSION : array(); }