From 0b279a2cbc3db0cb9a99e41f67d309fbf2410057 Mon Sep 17 00:00:00 2001 From: Simon Welsh Date: Thu, 1 Nov 2012 21:15:43 +1300 Subject: [PATCH] Changes ping to POST and clears Requirements for ping GET requests can, and do, get cached. Using POST forces them not to. Clears requirements so that the SecurityAdmin JS isn't injected. --- admin/code/LeftAndMain.php | 1 + admin/javascript/LeftAndMain.Ping.js | 1 + 2 files changed, 2 insertions(+) diff --git a/admin/code/LeftAndMain.php b/admin/code/LeftAndMain.php index a09d204af..b39a19469 100644 --- a/admin/code/LeftAndMain.php +++ b/admin/code/LeftAndMain.php @@ -403,6 +403,7 @@ class LeftAndMain extends Controller implements PermissionProvider { * This is used in the CMS. */ public function ping() { + Requirements::clear(); return 1; } diff --git a/admin/javascript/LeftAndMain.Ping.js b/admin/javascript/LeftAndMain.Ping.js index b129c9608..9638f6a15 100644 --- a/admin/javascript/LeftAndMain.Ping.js +++ b/admin/javascript/LeftAndMain.Ping.js @@ -40,6 +40,7 @@ $.ajax({ url: 'admin/security/ping', global: false, + type: 'POST', complete: onSessionLost }); }, this.getPingIntervalSeconds() * 1000);