tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

FIX Skip md5-ing the whole contents of a stream for etags

Browse Source
This commit is contained in:
Guy Marriott 2019-07-30 08:25:03 +12:00
parent 40f06fafa9
commit 0abfed3e06
No known key found for this signature in database
GPG Key ID: A80F9ACCB86D3DA7
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Control/Middleware/ChangeDetectionMiddleware.php
View File

@ -4,6 +4,7 @@ namespace SilverStripe\Control\Middleware;
use SilverStripe\Control\HTTPRequest; use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse; use SilverStripe\Control\HTTPResponse;
use SilverStripe\Control\HTTPStreamResponse;
use SilverStripe\Core\Injector\Injectable; use SilverStripe\Core\Injector\Injectable;
/** /**
@ -69,6 +70,11 @@ class ChangeDetectionMiddleware implements HTTPMiddleware
return $etag; return $etag;
} }
// Skip parsing the whole body of a stream
if ($response instanceof HTTPStreamResponse) {
return false;
}
// Generate etag from body // Generate etag from body
return sprintf('"%s"', md5($response->getBody())); return sprintf('"%s"', md5($response->getBody()));
} }