BUGFIX Renamed MySQLDatabase->clear_cached_fieldlist() to clearCachedFieldList() and moved to parent Database class in order to avoid breaking other database drivers (broken in 360176d2 by gmunn)

core/model/Database.php

@@ -115,6 +115,19 @@ abstract class SS_Database {
 	 * database expects.
 	 * @return array
 	 */
+	
+	/**
+	 *
+	 * This is a stub function.  Postgres caches the fieldlist results.
+	 *
+	 * @param string $tableName
+	 *
+	 * @return boolean
+	 */
+	function clearCachedFieldlist($tableName=false){
+		return true;
+	}
+	
 	protected abstract function tableList();
 	
 	

core/model/MySQLDatabase.php

@@ -358,18 +358,6 @@ class MySQLDatabase extends SS_Database {
 		return $fieldList;
 	}
 
-	/**
-	 *
-	 * This is a stub function.  Postgres caches the fieldlist results.
-	 *
-	 * @param string $tableName
-	 *
-	 * @return boolean
-	 */
-	function clear_cached_fieldlist($tableName=false){
-		return true;
-	}
-
 	/**
 	 * Create an index on a table.
 	 *

tests/model/DatabaseTest.php

@@ -32,8 +32,7 @@ class DatabaseTest extends SapphireTest {
 	function testRenameField() {
 		$conn = DB::getConn();
 
-		//Reset our cached fieldlists:
+		$conn->clearCachedFieldlist();
-		$conn->clear_cached_fieldlist();
 
 		$conn->renameField('DatabaseTest_MyObject', 'MyField', 'MyRenamedField');