tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

removing potentially invalid html in email

Browse Source 
The generic email template encapsulates the "body" content in a paragraph mark.  This is undesirable as it can lead to invalid HTML. Rather than using a paragraph, it is better to have a div encapsulating the content.

The underlying reason for this is that $Body is usually HTML and this can included block elements (div, p, etc...) that are not allowed within paragraphs (p).

It is important that the HTML is valid, because it will reduce the likelihood for it being marked as spam, because it is less likely to show up strange formatting and for use of tools like emogrifier.
This commit is contained in:
Nicolaas 2013-04-16 15:19:52 +12:00 committed by Ingo Schommer
parent 85202876a9
commit 08bf2aa91e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
templates/email/GenericEmail.ss
View File

@ -5,9 +5,9 @@
</head> </head>
<body> <body>
<p class="body"> <div class="body">
$Body $Body
</p> </div>
</body> </body>
</html> </html>