tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX Subtract should not add order by on subselect

Browse Source
This commit is contained in:
Stig Lindqvist 2012-01-27 18:27:24 +13:00
parent eef6450613
commit 056e564217
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
model/DataQuery.php
View File

@ -514,7 +514,6 @@ class DataQuery {
public function subtract(DataQuery $subtractQuery, $field='ID') { public function subtract(DataQuery $subtractQuery, $field='ID') {
$subSelect= $subtractQuery->getFinalisedQuery(); $subSelect= $subtractQuery->getFinalisedQuery();
$subSelect->select($this->expressionForField($field, $subSelect)); $subSelect->select($this->expressionForField($field, $subSelect));
$this->ensureSelectContainsOrderbyColumns($subSelect);
$this->where($this->expressionForField($field, $this).' NOT IN ('.$subSelect->sql().')'); $this->where($this->expressionForField($field, $this).' NOT IN ('.$subSelect->sql().')');
} }