From 04e9376a5a65a4f02ae091ee55207b05f5cfe1eb Mon Sep 17 00:00:00 2001 From: Ingo Schommer Date: Mon, 29 Feb 2016 21:17:38 +1300 Subject: [PATCH] Exclude node_modules from manifests Believe it or not, some node modules contain PHP files, which get included by default otherwise. This also fixes a performance regression on ?flush, the existence of node_modules will cause a lot of unneccesary file lookups. --- core/manifest/ManifestFileFinder.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/manifest/ManifestFileFinder.php b/core/manifest/ManifestFileFinder.php index 1ba3b79e7..27b3f447b 100644 --- a/core/manifest/ManifestFileFinder.php +++ b/core/manifest/ManifestFileFinder.php @@ -22,7 +22,8 @@ class ManifestFileFinder extends SS_FileFinder { protected static $default_options = array( 'include_themes' => false, 'ignore_tests' => true, - 'min_depth' => 1 + 'min_depth' => 1, + 'ignore_dirs' => array('node_modules') ); public function acceptDir($basename, $pathname, $depth) {