tonyair
/
silverstripe-framework
mirror of https://github.com/silverstripe/silverstripe-framework
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
silverstripe-framework/tests/integration/HTMLValueTest.php

52 lines
1.5 KiB
PHP
Raw Normal View History

BUGFIX: Suppressed errors in SS_HTMLValue->setContent() so it can handle malformed HTML. MINOR: Added tests for saving and managing invalid HTML with SS_HTMLValue. From: Andrew Short <andrewjshort@gmail.com> git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-13 03:44:41 +02:00
<?php
/**
MINOR Update @package values to match renaming sapphire
2012-04-12 08:02:46 +02:00
* @package framework
BUGFIX: Suppressed errors in SS_HTMLValue->setContent() so it can handle malformed HTML. MINOR: Added tests for saving and managing invalid HTML with SS_HTMLValue. From: Andrew Short <andrewjshort@gmail.com> git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-13 03:44:41 +02:00
* @subpackage tests
*/
class SS_HTMLValueTest extends SapphireTest {
public function testInvalidHTMLSaving() {
$value = new SS_HTMLValue();
$invalid = array (
'<p>Enclosed Value</p></p>' => '<p>Enclosed Value</p>',
BUG HtmlEditorField doesn't save HTML fragments in HTMLValue correctly The issue was raised in #7628, where an anchor tag was being changed from <a name="anchor"></a> to <a name="anchor"/> by SS_HTMLValue, when HtmlEditorField::saveInto() parses the HTML fragments. This is because SS_HTMLValue uses DOMDocument::saveXML(), which is fine for saving an XML document, but not suitable for HTML. This fix changes that to use DOMDocument::saveHTML() instead. Note that we can't use the parameter to saveHTML() for selecting a single node only, as that's only supported in PHP 5.3.6+, SilverStripe 3.0 supports PHP 5.3.2 as a minimum. The workaround for this shortcoming is to replace unncessary output by DOMDocument with a regular expression.
2012-09-14 07:31:12 +02:00
'<p><div class="example"></div></p>' => '<p></p><div class="example"></div>',
'<html><html><body><falsetag "attribute=""attribute""">' => '<falsetag></falsetag>',
BUGFIX: Suppressed errors in SS_HTMLValue->setContent() so it can handle malformed HTML. MINOR: Added tests for saving and managing invalid HTML with SS_HTMLValue. From: Andrew Short <andrewjshort@gmail.com> git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-13 03:44:41 +02:00
'<body<body<body>/bodu>/body>' => '/bodu&gt;/body&gt;'
);
foreach($invalid as $input => $expected) {
$value->setContent($input);
$this->assertEquals($expected, $value->getContent(), 'Invalid HTML can be saved');
}
}
public function testInvalidHTMLTagNames() {
$value = new SS_HTMLValue();
BUG HtmlEditorField doesn't save HTML fragments in HTMLValue correctly The issue was raised in #7628, where an anchor tag was being changed from <a name="anchor"></a> to <a name="anchor"/> by SS_HTMLValue, when HtmlEditorField::saveInto() parses the HTML fragments. This is because SS_HTMLValue uses DOMDocument::saveXML(), which is fine for saving an XML document, but not suitable for HTML. This fix changes that to use DOMDocument::saveHTML() instead. Note that we can't use the parameter to saveHTML() for selecting a single node only, as that's only supported in PHP 5.3.6+, SilverStripe 3.0 supports PHP 5.3.2 as a minimum. The workaround for this shortcoming is to replace unncessary output by DOMDocument with a regular expression.
2012-09-14 07:31:12 +02:00
$invalid = array(
BUGFIX: Suppressed errors in SS_HTMLValue->setContent() so it can handle malformed HTML. MINOR: Added tests for saving and managing invalid HTML with SS_HTMLValue. From: Andrew Short <andrewjshort@gmail.com> git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-13 03:44:41 +02:00
'<p><div><a href="test-link"></p></div>',
'<html><div><a href="test-link"></a></a></html_>',
'""\'\'\'"""\'""<<<>/</<htmlbody><a href="test-link"<<>'
);
foreach($invalid as $input) {
$value->setContent($input);
$this->assertEquals (
'test-link',
$value->getElementsByTagName('a')->item(0)->getAttribute('href'),
'Link data can be extraced from malformed HTML'
);
}
}
BUGFIX Ensure that windows-style newlines ("\r\n") don't get converted to their XML entity representation through DOMDocument in SS_HTMLValue->setContent() (from r111878) git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112935 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 07:03:29 +02:00
public function testMixedNewlines() {
$value = new SS_HTMLValue();
BUG HtmlEditorField doesn't save HTML fragments in HTMLValue correctly The issue was raised in #7628, where an anchor tag was being changed from <a name="anchor"></a> to <a name="anchor"/> by SS_HTMLValue, when HtmlEditorField::saveInto() parses the HTML fragments. This is because SS_HTMLValue uses DOMDocument::saveXML(), which is fine for saving an XML document, but not suitable for HTML. This fix changes that to use DOMDocument::saveHTML() instead. Note that we can't use the parameter to saveHTML() for selecting a single node only, as that's only supported in PHP 5.3.6+, SilverStripe 3.0 supports PHP 5.3.2 as a minimum. The workaround for this shortcoming is to replace unncessary output by DOMDocument with a regular expression.
2012-09-14 07:31:12 +02:00
$value->setContent("<p>paragraph</p>\n<ul><li>1</li>\r\n</ul>");
BUGFIX Ensure that windows-style newlines ("\r\n") don't get converted to their XML entity representation through DOMDocument in SS_HTMLValue->setContent() (from r111878) git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112935 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 07:03:29 +02:00
$this->assertEquals(
BUG HtmlEditorField doesn't save HTML fragments in HTMLValue correctly The issue was raised in #7628, where an anchor tag was being changed from <a name="anchor"></a> to <a name="anchor"/> by SS_HTMLValue, when HtmlEditorField::saveInto() parses the HTML fragments. This is because SS_HTMLValue uses DOMDocument::saveXML(), which is fine for saving an XML document, but not suitable for HTML. This fix changes that to use DOMDocument::saveHTML() instead. Note that we can't use the parameter to saveHTML() for selecting a single node only, as that's only supported in PHP 5.3.6+, SilverStripe 3.0 supports PHP 5.3.2 as a minimum. The workaround for this shortcoming is to replace unncessary output by DOMDocument with a regular expression.
2012-09-14 07:31:12 +02:00
"<p>paragraph</p>\n<ul><li>1</li>\n</ul>",
BUGFIX Ensure that windows-style newlines ("\r\n") don't get converted to their XML entity representation through DOMDocument in SS_HTMLValue->setContent() (from r111878) git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112935 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 07:03:29 +02:00
$value->getContent(),
'Newlines get converted'
);
}
MINOR Add newline to end of files without one
2012-03-24 04:04:52 +01:00
}