Commit Graph

201 Commits

Author SHA1 Message Date
Damian Mooyman
b219ebb52e Merge pull request #8 from silverstripe-labs/pulls/avoid-hamcrest-globals
Include Hamcrest without clashing with PHPUnit globals
2015-05-28 09:21:57 +12:00
Ingo Schommer
38659bac98 Include Hamcrest without clashing with PHPUnit globals
PHPUnit had a Functions.php with global methods like any() for a while (3.7 at least),
which clashes with similar globals from Hamcrest (used in Phockito).

Both PHPUnit and Phockito use 'classmap' composer autoloading,
but that's not directly requiring/evaluating the files.
The problem is caused by SilverStripe's ClassLoader
which does require ALL subclasses of SapphireTest.
This in turn causes PHP outside of the class context to execute,
which includes Hamcrest.

Changing the include_hamcrest() is not strictly necessary here,
but makes the code a bit more resilient against any preceding
test including Functions.php from PHPUnit.

See https://github.com/hafriedlander/phockito/issues/32 for context.
2015-04-29 14:28:08 +12:00
Damian Mooyman
a35241cd10 Update translations 2014-11-19 09:54:06 +13:00
Damian Mooyman
f2b4c7b7a2 Merge pull request #7 from halkyon/indicator_fixes
BUG Indicator stuck on 0% until you refresh the page.
2014-08-13 17:36:12 +12:00
Sean Harvey
65117b2599 BUG Indicator stuck on 0% until you refresh the page.
admin/externallinks/start is called, but asynchronously, so the poll()
call is never called immediately on start, you have to refresh the page
to get it to show.
2014-08-13 15:39:29 +12:00
Damian Mooyman
2a286fd582 Merge pull request #6 from halkyon/vis_changes
Removing unused static funcs and moving existing statics to top of class
2014-08-13 14:58:55 +12:00
Sean Harvey
2a3f99b2cd Removing unused static funcs and moving existing statics to top of class. 2014-08-13 14:49:47 +12:00
Damian Mooyman
5a4682cdc0 Merge pull request #5 from halkyon/method_vis
Fixing static visibility and moving method to underneath statics
2014-08-13 14:31:51 +12:00
Sean Harvey
3431448657 Fixing static visibility and moving method to underneath statics 2014-08-13 14:27:40 +12:00
Damian Mooyman
606c801513 Merge pull request #4 from halkyon/export_csv_columns
Fixing CSV export columns to match the ones show in broken links report
2014-08-13 14:26:50 +12:00
Sean Harvey
aef8f6f521 Fixing CSV export columns to match the ones show in broken links report 2014-08-13 14:23:03 +12:00
Damian Mooyman
a283b6b69f Merge pull request #3 from halkyon/visibility_info
Fixing CurlLinkChecker::checkLink() using incorrect visibility
2014-08-13 14:08:12 +12:00
Sean Harvey
486ccec95c Fixing CurlLinkChecker::checkLink() using incorrect visibility 2014-08-13 13:48:33 +12:00
Sean Harvey
d9e1b998d7 Merge pull request #1 from tractorcow/pulls/description
API Add description for response code to report
2014-08-13 11:08:56 +12:00
Sean Harvey
7698ba9ef2 Merge pull request #2 from tractorcow/pulls/docs
Update docs
2014-08-13 11:02:45 +12:00
Damian Mooyman
1aa5491d6a Update docs 2014-08-13 10:57:41 +12:00
Damian Mooyman
7328344408 API Add description for response code to report 2014-08-13 10:20:39 +12:00
Damian Mooyman
1fb59f9247 Fix incorrect function visibility 2014-08-13 09:17:02 +12:00
Damian Mooyman
ec4c47915a Update travis, composer, license 2014-08-07 16:49:20 +12:00
Damian Mooyman
a4ede246ab Tests, refactor, cleanup, fix issues 2014-08-07 15:24:20 +12:00
Kirk Mayo
f55a650d24 NEW: Plat-59 Do not display broken previous report info for the latest report 2014-08-06 15:11:23 +12:00
Kirk Mayo
6bda4dcc82 BUG: Correcting test code and fixing bug with create report button 2014-08-04 17:38:28 +12:00
Kirk Mayo
da7e45ddd4 BUG: Fixing report page link and set to check stage not live 2014-08-04 15:26:22 +12:00
kmayo-ss
5a1c636264 Merge pull request #3 from tractorcow/pulls/fix-tmp-loop
Make sure that process yields to queuedjobs after each page
2014-08-04 11:26:28 +12:00
Damian Mooyman
363ecd4985 Make sure that process yields to queuedjobs after each page
Fix javascript errors starting the job
2014-08-04 11:20:54 +12:00
Kirk Mayo
9e5a41f6c7 NEW: Fixing queuedjob status and hiding report button when report is running 2014-08-04 10:10:59 +12:00
Kirk Mayo
e9fe1a4707 NEW: Use DB row for job status and refactor the sql statements 2014-08-01 12:48:30 +12:00
Kirk Mayo
564514b015 NEW: Adding whitelisted codes via yml 2014-07-30 15:29:24 +12:00
Kirk Mayo
093322fcd3 NEW: Adding a option to run a batch job to the front end 2014-07-30 12:44:00 +12:00
Kirk Mayo
d25adca175 NEW: Adding tests and code tidyup 2014-07-29 09:31:22 +12:00
Kirk Mayo
bb30288252 NEW: Adding report link to setup new queued job 2014-07-28 13:47:26 +12:00
Kirk Mayo
a3c693189b NEW: Adding back in the Broken links model no model admin this time though 2014-07-24 14:50:14 +12:00
Kirk Mayo
72dc652ecd NEW: Setting up Queued job and task to support being sent a single page 2014-07-24 14:38:44 +12:00
Kirk Mayo
3b976fd408 NEW: Adding link tracking css class and using built in reporting 2014-07-23 14:34:49 +12:00
Kirk Mayo
9708dfd074 BUG: Fixing Link definition in BrokenExternalLinks 2013-08-26 15:41:50 +12:00
Kirk Mayo
1641007fff NEW: Modifying README 2013-08-26 15:41:07 +12:00
Kirk Mayo
1803f0cdd5 BUG: Extned the size of the varchar for Link in BrokenExternalLinks 2013-08-26 15:34:38 +12:00
Kirk Mayo
d62c7e57ac BUG: Changed the model admin title for the http code search field 2013-08-26 15:12:32 +12:00
Kirk Mayo
01b89a1a85 BUG: Adding support for PostgreSQL 2013-08-26 14:52:02 +12:00
Kirk Mayo
cbbd0a6a4d BUG: Added a TODO code comment and mentioned it in the README 2013-08-26 14:20:29 +12:00
Kirk Mayo
01b03bf911 BUG: Moved BrokenExternalLinks.php to a model folder in code 2013-08-26 14:17:41 +12:00
Kirk Mayo
1216744e53 BUG: Moved jobs and tasks folder to code 2013-08-26 14:16:18 +12:00
Kirk Mayo
7602816d78 NEW: Adding queued jobs functionality 2013-08-26 14:14:50 +12:00
Kirk Mayo
8753c9337a BUG: Removed swp files from respository 2013-08-26 12:56:05 +12:00
Kirk Mayo
8af00878cb BUG: Correcteing task instance name and calling completeJob 2013-08-26 12:53:01 +12:00
Kirk Mayo
91b1ae4354 NEW: Adding a queued job if queuedjobs is installed 2013-08-26 12:24:36 +12:00
Kirk Mayo
7c215393f3 BUG: Used continue instead of return to stop foreach returning early 2013-08-26 11:29:27 +12:00
kmayo-ss
106d18cb8e BUG: Fixed JSON in composer.json 2013-08-26 10:06:00 +12:00
kmayo-ss
1f6e5bc0ea BUG: Set CMS and framework support to be at least 3.0 2013-08-26 10:05:02 +12:00
Kirk Mayo
f409322c7d NEW: Added composer support 2013-08-26 09:55:24 +12:00