tonyair/silverstripe-externallinks
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-externallinks.git synced 2024-10-22 15:05:44 +00:00
Code Issues Projects Releases Wiki Activity

FIX Exclude links attached to archived Pages from report (#72)

Browse Source
This commit is contained in:
Garion Herman 2021-02-04 09:45:39 +13:00 committed by GitHub
parent 7b68fe0eaa
commit b4c210f211
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Reports/BrokenExternalLinksReport.php
View File

@ -71,7 +71,8 @@ class BrokenExternalLinksReport extends Report
{ {
$track = BrokenExternalPageTrackStatus::get_latest(); $track = BrokenExternalPageTrackStatus::get_latest();
if ($track) { if ($track) {
return $track->BrokenLinks(); // Filter items that are attached to archived Pages
return $track->BrokenLinks()->exclude('Track.Page.ID', null);
} }
return ArrayList::create(); return ArrayList::create();
} }

18
tests/ExternalLinksTest.php
View File

@ -107,4 +107,22 @@ class ExternalLinksTest extends SapphireTest
'BrokenExternalLinksReport is in reports list' 'BrokenExternalLinksReport is in reports list'
); );
} }
public function testArchivedPagesAreHiddenFromReport()
{
// Run link checker
$task = CheckExternalLinksTask::create();
$task->setSilent(true); // Be quiet during the test!
$task->runLinksCheck();
// Ensure report lists all broken links
$this->assertEquals(4, BrokenExternalLinksReport::create()->sourceRecords()->count());
// Archive a page
$page = $this->objFromFixture(ExternalLinksTestPage::class, 'page1');
$page->doArchive();
// Ensure report does not list the link associated with an archived page
$this->assertEquals(3, BrokenExternalLinksReport::create()->sourceRecords()->count());
}
} }