tonyair
/
silverstripe-externallinks
mirror of https://github.com/silverstripe/silverstripe-externallinks.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #39 from creative-commoners/pulls/2.0/handle-obsolete-class-names 

FIX Handle thrown exceptions because of obsolete class names
This commit is contained in:
Dylan Wagstaff 2017-11-29 14:57:44 +13:00 committed by GitHub
parent e21c0ad470 c9f5ca6c72
commit 6cf7a466fb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Tasks/CheckExternalLinksTask.php
View File

@ -14,6 +14,7 @@ use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrackStatus;
use SilverStripe\ExternalLinks\Tasks\LinkChecker;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB;
use SilverStripe\ORM\ValidationException;
class CheckExternalLinksTask extends BuildTask
{
@ -194,7 +195,12 @@ class CheckExternalLinksTask extends BuildTask
// Update content of page based on link fixes / breakages
$htmlValue->saveHTML();
$page->Content = $htmlValue->getContent();
$page->write();
try {
$page->write();
} catch (ValidationException $ex) {
$this->log("Exception caught for {$page->Title}, skipping. Message: " . $ex->getMessage());
continue;
}
// Once all links have been created for this page update HasBrokenLinks
$count = $pageTrack->BrokenLinks()->count();