mirror of
https://github.com/silverstripe/silverstripe-externallinks.git
synced 2024-10-22 17:05:44 +02:00
FIX Use correct CacheInterface API methods and remove doubled up logic
This commit is contained in:
parent
65a9f11708
commit
39044de8ad
@ -54,22 +54,15 @@ class CurlLinkChecker implements LinkChecker
|
||||
return null;
|
||||
}
|
||||
|
||||
$cacheKey = md5($href);
|
||||
if (!$this->config()->get('bypass_cache')) {
|
||||
// Check if we have a cached result
|
||||
$cacheKey = md5($href);
|
||||
$result = $this->getCache()->load($cacheKey);
|
||||
$result = $this->getCache()->get($cacheKey, false);
|
||||
if ($result !== false) {
|
||||
return $result;
|
||||
}
|
||||
}
|
||||
|
||||
// Check if we have a cached result
|
||||
$cacheKey = md5($href);
|
||||
$result = $this->getCache()->get($cacheKey, false);
|
||||
if ($result !== false) {
|
||||
return $result;
|
||||
}
|
||||
|
||||
// No cached result so just request
|
||||
$handle = curl_init($href);
|
||||
curl_setopt($handle, CURLOPT_RETURNTRANSFER, true);
|
||||
@ -84,7 +77,7 @@ class CurlLinkChecker implements LinkChecker
|
||||
|
||||
if (!$this->config()->get('bypass_cache')) {
|
||||
// Cache result
|
||||
$this->getCache()->save($httpCode, $cacheKey);
|
||||
$this->getCache()->set($cacheKey, $httpCode);
|
||||
}
|
||||
return $httpCode;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user