From 1ce8c3bbdf2fb5f7b3234198ef1bcee868a654b4 Mon Sep 17 00:00:00 2001 From: Robbie Averill Date: Fri, 26 Jul 2019 11:16:31 +0200 Subject: [PATCH] FIX Add missing namespace import - unknown HTTP status codes are now handled --- src/Model/BrokenExternalLink.php | 6 +++-- tests/Model/BrokenExternalLinkTest.php | 35 ++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 2 deletions(-) create mode 100644 tests/Model/BrokenExternalLinkTest.php diff --git a/src/Model/BrokenExternalLink.php b/src/Model/BrokenExternalLink.php index 366057a..d7a1bea 100644 --- a/src/Model/BrokenExternalLink.php +++ b/src/Model/BrokenExternalLink.php @@ -2,9 +2,9 @@ namespace SilverStripe\ExternalLinks\Model; +use InvalidArgumentException; +use SilverStripe\CMS\Model\SiteTree; use SilverStripe\Control\HTTPResponse; -use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrack; -use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrackStatus; use SilverStripe\ORM\DataObject; use SilverStripe\Security\Permission; use SilverStripe\Security\Security; @@ -12,6 +12,8 @@ use SilverStripe\Security\Security; /** * Represents a single link checked for a single run that is broken * + * @property string Link + * @property int HTTPCode * @method BrokenExternalPageTrack Track() * @method BrokenExternalPageTrackStatus Status() */ diff --git a/tests/Model/BrokenExternalLinkTest.php b/tests/Model/BrokenExternalLinkTest.php new file mode 100644 index 0000000..4160304 --- /dev/null +++ b/tests/Model/BrokenExternalLinkTest.php @@ -0,0 +1,35 @@ +HTTPCode = $httpCode; + $this->assertSame($expected, $link->getHTTPCodeDescription()); + } + + /** + * @return array[] + */ + public function httpCodeProvider() + { + return [ + [200, '200 (OK)'], + [302, '302 (Found)'], + [404, '404 (Not Found)'], + [500, '500 (Internal Server Error)'], + [789, '789 (Unknown Response Code)'], + ]; + } +}