tonyair/silverstripe-environmentcheck
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-environmentcheck synced 2024-10-22 17:05:40 +02:00
Code Issues Projects Releases Wiki Activity

Fix environment check basic auth tests

Browse Source 
Was assuming that Member::currentMember() is set,
which isn't the case unless you log in beforehand and start a PHP session.

Given we want the checks to run on their own without user interaction,
they need to work in isolation through a single HTTP call containing
the basic auth info.
This commit is contained in:
Ingo Schommer 2015-06-11 11:24:05 +12:00
parent 98126dc448
commit 631b7ba502
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
code/EnvironmentChecker.php
View File

@ -60,7 +60,13 @@ class EnvironmentChecker extends RequestHandler {
} }
function canAccess($member = null, $permission = "ADMIN") { function canAccess($member = null, $permission = "ADMIN") {
if(!$member) $member = Member::currentUser(); if(!$member) {
$member = Member::currentUser();
}
if(!$member) {
$member = BasicAuth::requireLogin('Environment Checker', $permission, false);
}
// We allow access to this controller regardless of live-status or ADMIN permission only // We allow access to this controller regardless of live-status or ADMIN permission only
// if on CLI. Access to this controller is always allowed in "dev-mode", or of the user is ADMIN. // if on CLI. Access to this controller is always allowed in "dev-mode", or of the user is ADMIN.