tonyair/silverstripe-environmentcheck
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-environmentcheck synced 2024-10-22 15:05:40 +00:00
Code Issues Projects Releases Wiki Activity

Avoid 100% CPU on curl_multi_exec

Browse Source 
Never finishes (up to max_execlution_limit) on PHP 5.4.24.

See http://nz1.php.net/curl_multi_exec#113002
and http://www.adrianworlddesign.com/Knowledge-Base/php/Download-content-with-cURL/Doing-curlmultiexec-the-right-way
This commit is contained in:
Ingo Schommer 2014-05-12 16:41:39 +12:00
parent 815a1ad6db
commit 2bbcde2b64
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
code/checks/ExternalURLCheck.php
View File

@ -45,7 +45,8 @@ class ExternalURLCheck implements EnvironmentCheck {
// Execute the handles
do {
$mrc = curl_multi_exec($mh, $active);
} while ($mrc == CURLM_CALL_MULTI_PERFORM);
curl_multi_select($mh);
} while ($active > 0);
while ($active && $mrc == CURLM_OK) {
if (curl_multi_select($mh) != -1) {