BUGFIX Fixed 404 display

code/DocumentationService.php

@@ -552,6 +552,8 @@ class DocumentationService {
 
 		$folder = Controller::join_links($base, $relative);
 		
+		if(!is_dir($folder)) return false;
+			
 		$handle = opendir($folder);
 
 		if($handle) {

code/DocumentationViewer.php

@@ -492,11 +492,13 @@ class DocumentationViewer extends Controller {
 			return DBField::create("HTMLText", $html);
 		}
 		else {
-			// if no page found then we may want to get the listing of
-			// the folder
-			if($url = $this->Remaining) {
-				$pages = DocumentationService::get_pages_from_folder($this->getModule(), implode('/', $url), false);
-
+			// If no page found then we may want to get the listing of the folder.
+			// In case no folder exists, show a "not found" page.
+			$module = $this->getModule();
+			$url = $this->Remaining;
+			if($url && $module) {
+				$pages = DocumentationService::get_pages_from_folder($module, implode('/', $url), false);
+				// If no pages are found, the 404 is handled in the same template
 				return $this->customise(array(
 					'Title' => DocumentationService::clean_page_name(array_pop($url)),
 					'Pages' => $pages

templates/DocFolderListing.ss

@@ -9,5 +9,5 @@
 		</ul>
 	</div>
 <% else %>
-	<p>Nothing to see here</p>
+	<% include DocNotFound %>
 <% end_if %>

templates/Includes/DocNotFound.ss

@@ -0,0 +1,24 @@
+					<div class="warningBox" id="pageNotFoundWarning">
+						<div class="warningBoxTop">
+							<h1>We're sorry&#8230;</h1>
+							<p>The page you are looking for does not exist, or might have moved.
+							<h5>Perhaps you could&#8230;</h5>
+							<p>return to the <a href="$BaseHref">homepage</a> or try searching (see input box on the top right).</p>
+		
+							<!-- 
+								<h5>Search results for similar/related phrases</h5>
+								<ul class="resetStyle">
+									<li><a href="#">Installing</a></li>
+									<li><a href="#">Upgrading</a></li>
+									<li><a href="#">Server-requirements</a></li>
+									<li><a href="#">Suggested-web-hosts</a></li>
+								</ul> 
+							-->
+							</div>
+							<!-- <div class="warningBoxBottom">
+								<ul>
+									<li><a href="#">Report a missing link</a></li>
+									<li><a href="#">Report a bug or a concren</a></li>
+								</ul>
+						</div> -->
+					</div>

templates/Includes/DocTableOfContents.ss

@@ -1 +1,3 @@
-<div id="table-of-contents" class="sidebar-box"></div>
+<% if Content %>
+	<div id="table-of-contents" class="sidebar-box"></div>
+<% end_if %>

templates/Layout/DocumentationViewer.ss

@@ -3,12 +3,14 @@
 		<% if Content %>
 			$Content
 		<% else %>
-			<p>Woops page not found</p>
+			<% include DocNotFound %>
 		<% end_if %>
 	</div>
 
+	<% if Content %>
 	<div id="right-column">
 		<% include DocTableOfContents %>
 		<% include DocInThisModule %>
 	</div>
+	<% end_if %>
 </div>