tonyair/silverstripe-docsviewer
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-docsviewer synced 2024-10-22 11:05:56 +02:00
Code Issues Projects Releases Wiki Activity

Fix: no search results found on documentation homepage

Browse Source 
On the homepage there are no searchedEntities nor searchedVersions
defined, so the searchForm creates empty hiddenfields. PerformSeach
creates subqueries for thes empty values resulting in the return of an
'Empty' query object.

Solution: do not create these fields when there are no entities/versions
This commit is contained in:
martimiz 2013-01-07 16:53:33 +01:00
parent 5bf5da4c92
commit 0bd844e139
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
code/controllers/DocumentationViewer.php
View File

@ -816,10 +816,19 @@ class DocumentationViewer extends Controller {
if(!DocumentationSearch::enabled()) return false; if(!DocumentationSearch::enabled()) return false;
$q = ($q = $this->getSearchQuery()) ? $q->NoHTML() : ""; $q = ($q = $this->getSearchQuery()) ? $q->NoHTML() : "";
$entities = $this->getSearchedEntities();
$versions = $this->getSearchedVersions();
$fields = new FieldList( $fields = new FieldList(
new TextField('Search', _t('DocumentationViewer.SEARCH', 'Search'), $q), new TextField('Search', _t('DocumentationViewer.SEARCH', 'Search'), $q)
new HiddenField('Entities', '', implode(',', array_keys($this->getSearchedEntities()))), );
new HiddenField('Versions', '', implode(',', $this->getSearchedVersions()))
if ($entities) $fields->push(
new HiddenField('Entities', '', implode(',', array_keys($entities)))
);
if ($versions) $fields->push(
new HiddenField('Versions', '', implode(',', $versions))
); );
$actions = new FieldList( $actions = new FieldList(