Commit Graph

22 Commits

Author SHA1 Message Date
Guy Sartorelli
cd1b9ed9f2
ENH Use symfony/validation logic (#261) 2024-10-02 14:40:25 +13:00
Guy Sartorelli
47245c3c19
API Update API to reflect changes to CLI interaction (#255) 2024-09-27 09:58:45 +12:00
Guy Sartorelli
ef588a5ee0
Merge branch '5' into 6
# Conflicts:
#	composer.json
#	src/Tasks/ContentReviewEmails.php
2024-09-26 09:24:45 +12:00
Guy Sartorelli
40e45cda53
API Deprecate isValidEmail() method (#262) 2024-09-25 16:11:45 +12:00
Guy Sartorelli
4b8f7586d2
API Use new names for renamed classes (#258) 2024-09-23 14:40:25 +12:00
Steve Boyd
7d086ceb82 DEP Use PHPUnit 11 2024-09-18 13:53:15 +12:00
Sabina Talipova
c37f61861f MNT Remove TODO comments 2023-10-27 10:44:13 +13:00
Sabina Talipova
36d3718581 ENH Add Exception with list of invilid emails 2023-04-13 10:13:08 +12:00
Sabina Talipova
24766e4e5a FIX Notification job marked as broken 2023-04-12 08:56:49 +12:00
Steve Boyd
6f18e92169 API Stop using deprecated API 2022-11-24 13:04:34 +13:00
Mo Alsharaf
1cf0f01a35
NEW Allow for optional can permission method for content review (#152)
* Allow for optional can permission method for content review

* Content Review permission logic

With the new `canReviewContent()` permission checker we only need to check the permission is set for the user and `canBeReviewedBy()` will always check if the page object is due for review by its owner.

Thus removed redundant logic in `canUseReviewContent()` and accordingly renamed the class filename for additional context.

Co-authored-by: Jared Dreyer <jared.dreyer@silverstripe.com>
2022-06-22 12:25:59 +12:00
Guy Sartorelli
141e8d0bf3
ENH: Respect sort and limit arguments (#158)
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
2022-03-11 09:14:06 +13:00
Steve Boyd
89f58ec573 API phpunit 9 support 2021-11-01 14:35:22 +13:00
Daniel Hensby
c89a759af6
Add test 2021-05-14 11:15:09 +01:00
Massey Isa'ako
cf35e056b6 BUGFIX: Remove pages from content review email list, if a review log submitted after review date (#98) 2018-08-14 15:43:10 +12:00
Dan Hensby
6b5bc12f31
FIX Use assertListEquals 2018-07-31 00:55:50 +01:00
Guy Marriott
8e73114051
FIX Updating test to not assert order of results 2018-07-31 09:26:49 +12:00
Robbie Averill
ca9faaf4bd Disable transactions in SiteTreeContentReview test 2018-06-20 18:51:00 +12:00
Raissa North
e55931f874 FIX Simplify JS requirements in SiteTreeContentReview and fix linting errors 2018-01-09 12:31:12 +13:00
Raissa North
ad2932c418 ENHANCEMENT Optimise imports, upgrade array syntax 2018-01-09 12:26:55 +13:00
Robbie Averill
a55d5c285a Merge branch '3' 2017-10-12 13:22:24 +13:00
Robbie Averill
31bcd0d439 NEW Add behat tests to cover content review configuration and review modal
* Update existing test for review button field name, remove obsolete save review test
* Move test classes to tests/php to differentiate from behat
* Add behat build to Travis configuration
2017-09-15 16:06:38 +12:00