Commit Graph

38 Commits

Author SHA1 Message Date
Michal Kleiner
2e22bd4900 MNT Use ::create to allow Injector to replace content review emails sending task 2023-06-16 11:46:30 +12:00
Sabina Talipova
c39e588306 FIX Notification job marked as broken 2023-04-14 12:22:23 +12:00
Sabina Talipova
55d52cb7dc
Merge pull request #155 from creative-commoners/pulls/4.3/all-sections
FIX Allow users with the CMS_ACCESS_LeftAndMain permission to be added
2022-09-15 15:14:52 +12:00
Mo Alsharaf
1cf0f01a35
NEW Allow for optional can permission method for content review (#152)
* Allow for optional can permission method for content review

* Content Review permission logic

With the new `canReviewContent()` permission checker we only need to check the permission is set for the user and `canBeReviewedBy()` will always check if the page object is due for review by its owner.

Thus removed redundant logic in `canUseReviewContent()` and accordingly renamed the class filename for additional context.

Co-authored-by: Jared Dreyer <jared.dreyer@silverstripe.com>
2022-06-22 12:25:59 +12:00
Steve Boyd
856660192b ENH PHP 8.1 compatibility 2022-04-13 10:23:56 +12:00
Guy Sartorelli
141e8d0bf3
ENH: Respect sort and limit arguments (#158)
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
2022-03-11 09:14:06 +13:00
Steve Boyd
89f58ec573 API phpunit 9 support 2021-11-01 14:35:22 +13:00
Steve Boyd
a821edf8d7 FIX Allow users with the CMS_ACCESS_LeftAndMain permission to be added 2021-09-14 13:53:32 +12:00
Jules
ebcfc483be
FIX: Clear non-recurring custom date when reviewing 2021-05-14 10:41:14 +01:00
Robbie Averill
6bc589c741 FIX Replace Convert JSON methods with json_* methods, deprecated from SilverStripe 4.4 2018-10-28 21:32:15 +00:00
pjayme
d5b4fe1929 changed 'option' variable name to 'options' in places its used 2018-08-22 08:43:44 +12:00
pjayme
156a76a8e5 BUGFIX: Error trying to access OwnerGroups() method on boolean value 2018-08-22 08:20:36 +12:00
Saophalkun Ponlu
68b1616d22 BUGFIX: Error trying to OwnerGroups() method on boolean value
This issue occurs when a page has "Inherit from parent page" for content
review option and a review date, and its parent has "Disable content
review" for content review option.
2018-08-21 09:27:05 +12:00
Massey Isa'ako
cf35e056b6 BUGFIX: Remove pages from content review email list, if a review log submitted after review date (#98) 2018-08-14 15:43:10 +12:00
Robbie Averill
6c56694bde BUG Update modal API for Reactstrap in SilverStripe 4.2, bump constraint 2018-06-25 13:22:15 +12:00
Daniel Hensby
d989d4c68e
Linting fixes 2018-06-20 10:58:54 +01:00
Daniel Hensby
92770b01c6
Merge branch '3.0' into 4.0 2018-06-20 10:45:28 +01:00
Robbie Averill
dd7d1a70ec FIX Remove automatically scaffolded GridField for Site Tree Content Review in Member fields 2018-03-22 17:09:57 +13:00
Raissa North
e55931f874 FIX Simplify JS requirements in SiteTreeContentReview and fix linting errors 2018-01-09 12:31:12 +13:00
Raissa North
f64561e1b4 API Remove Translatable compatibility logic 2018-01-09 12:26:56 +13:00
Raissa North
ad2932c418 ENHANCEMENT Optimise imports, upgrade array syntax 2018-01-09 12:26:55 +13:00
Raissa North
edef740ff1 Update translations and update classes to use __CLASS__ in translations 2018-01-09 11:20:50 +13:00
cpenny
f490ad77cd Add a hook to updateSettingsFields so that devs can show/hide when desired. 2017-11-21 09:18:31 +13:00
Daniel Hensby
c15b550b2f Merge pull request #70 from creative-commoners/pulls/4.0/vendorise
NEW Install module to the vendor folder
2017-10-12 11:27:00 +01:00
Robbie Averill
a55d5c285a Merge branch '3' 2017-10-12 13:22:24 +13:00
Robbie Averill
b720acb705 NEW Install module to the vendor folder 2017-10-12 09:41:01 +13:00
Robbie Averill
4e7792a132 FIX Use ModuleLoader for requirements, and use path resolver for thirdparty dir 2017-09-15 16:06:38 +12:00
Robbie Averill
31bcd0d439 NEW Add behat tests to cover content review configuration and review modal
* Update existing test for review button field name, remove obsolete save review test
* Move test classes to tests/php to differentiate from behat
* Add behat build to Travis configuration
2017-09-15 16:06:38 +12:00
Robbie Averill
8b8b8e3620 API Add React modal popup for reviewing content in SiteTree
* Add i18n javascript source file and Transifex configuration
* Add npm requirements, React + entwine wrapper for CMS
* Overload LeftAndMain::getSchema... methods in extension so they can be used
* Refactor CSS to only the content review button
2017-09-15 16:06:37 +12:00
Robbie Averill
07f24bbd63 FIX Import DateTimeField class for GridField column casting 2017-09-13 11:16:47 +12:00
Will Rossiter
05fb6fa217 Use square arrays 2017-09-11 12:56:05 +12:00
Robbie Averill
038c41f5bf FIX Change right title to description for alignment 2017-09-07 16:20:29 +12:00
Robbie Averill
a93d8046f4 API Move JS and CSS to webpack, update DOM binding for SS4 CMS 2017-09-07 16:20:29 +12:00
Robbie Averill
cc7763afa4 FIX Import QueuedJobService namespace in job classes 2017-09-07 16:14:37 +12:00
Robbie Averill
de6ca323e0 FIX Add namespace import for Member 2017-09-07 09:29:27 +12:00
Robbie Averill
c5f9da17d0 FIX Missing namespace imports, incorrect date formats and array keys 2017-09-06 17:12:31 +12:00
Robbie Averill
42fb360fb2 API Implement namespaces and update core API use - CLDR date formats in progress 2017-09-06 17:12:31 +12:00
Robbie Averill
5ae95eda35 Move code to src for PSR-4 autoloading 2017-09-06 17:12:03 +12:00