Mo Alsharaf
1cf0f01a35
NEW Allow for optional can permission method for content review ( #152 )
...
* Allow for optional can permission method for content review
* Content Review permission logic
With the new `canReviewContent()` permission checker we only need to check the permission is set for the user and `canBeReviewedBy()` will always check if the page object is due for review by its owner.
Thus removed redundant logic in `canUseReviewContent()` and accordingly renamed the class filename for additional context.
Co-authored-by: Jared Dreyer <jared.dreyer@silverstripe.com>
2022-06-22 12:25:59 +12:00
Guy Sartorelli
141e8d0bf3
ENH: Respect sort and limit arguments ( #158 )
...
These parameters are defined in the PHPDocs for `Report` and are technically part of the method signature. They should be respected and in the case of the new default limit in silverstripe/silverstripe-reports#139 this could have performance ramifications for large datasets.
2022-03-11 09:14:06 +13:00
Steve Boyd
f816052f06
MNT Update behat tests
2021-11-12 18:24:50 +13:00
Steve Boyd
89f58ec573
API phpunit 9 support
2021-11-01 14:35:22 +13:00
Daniel Hensby
c89a759af6
Add test
2021-05-14 11:15:09 +01:00
Steve Boyd
ad22d6b805
Fix behat test and update travis matrix
2020-01-29 16:53:49 +13:00
Massey Isa'ako
cf35e056b6
BUGFIX: Remove pages from content review email list, if a review log submitted after review date ( #98 )
2018-08-14 15:43:10 +12:00
Dan Hensby
6b5bc12f31
FIX Use assertListEquals
2018-07-31 00:55:50 +01:00
Guy Marriott
8e73114051
FIX Updating test to not assert order of results
2018-07-31 09:26:49 +12:00
Robbie Averill
ca9faaf4bd
Disable transactions in SiteTreeContentReview test
2018-06-20 18:51:00 +12:00
Raissa North
e55931f874
FIX Simplify JS requirements in SiteTreeContentReview and fix linting errors
2018-01-09 12:31:12 +13:00
Raissa North
ad2932c418
ENHANCEMENT Optimise imports, upgrade array syntax
2018-01-09 12:26:55 +13:00
Robbie Averill
a55d5c285a
Merge branch '3'
2017-10-12 13:22:24 +13:00
Robbie Averill
11a5dc7617
FIX Ensure SiteConfig defaults are used as fallback options
2017-10-06 16:39:53 +13:00
Robbie Averill
31bcd0d439
NEW Add behat tests to cover content review configuration and review modal
...
* Update existing test for review button field name, remove obsolete save review test
* Move test classes to tests/php to differentiate from behat
* Add behat build to Travis configuration
2017-09-15 16:06:38 +12:00
Robbie Averill
c5f9da17d0
FIX Missing namespace imports, incorrect date formats and array keys
2017-09-06 17:12:31 +12:00
Robbie Averill
42fb360fb2
API Implement namespaces and update core API use - CLDR date formats in progress
2017-09-06 17:12:31 +12:00
Robbie Averill
12198e21e6
FIX Remove specific page edit URL from tests to ensure multi SS version compatibility
2017-06-15 14:47:25 +12:00
Damian Mooyman
d75cf9e280
BUG Prevent non-real draft changes forcing record to appear as changed when saved
2016-05-17 17:57:48 +12:00
helpfulrobot
98c125360b
Converted to PSR-2
2015-11-18 16:38:28 +13:00
Damian Mooyman
d9729bf7f1
API CMS Editable notification templates
...
PSR-2 Coding fixup
2015-11-18 13:25:54 +13:00
Damian Mooyman
affee4bb85
BUG Show inherited date even when inheriting settings
2015-11-18 11:58:57 +13:00
Damian Mooyman
97adaee9a5
Merge pull request #32 from flashbackzoo/pulls/add-user-filter
...
Add report filter for only the pages a user is assigned to
2015-11-18 10:30:51 +13:00
David Craig
fc6caa2011
Add report filter for only the pages a user is assigned to
2015-11-18 09:44:08 +13:00
scott1702
0610b12a4a
Make contentreview an inline form
2015-11-13 14:51:09 +13:00
Damian Mooyman
5056615cf2
BUG Fix form saving
2015-11-03 17:18:48 +13:00
Christopher Pitt
61fd586533
Fixed code style
2015-11-02 12:53:31 +13:00
Christopher Pitt
119e6e59d8
Cleaned up tests and Badges
2015-10-29 13:12:27 +13:00
Igor Nadj
93a60eb455
ENH: compatability with other modules
2015-09-23 10:32:23 +12:00
Stig Lindqvist
9317dbaa8c
Moved out common functionality to a static method
2014-03-07 14:58:57 +13:00
Stig Lindqvist
4c88574799
BUG When setting up a new site, the default pages will not inherit a review date from siteconfig #20
2014-02-27 11:07:34 +13:00
Stig Lindqvist
ea44b0026e
Fixed the ContentReviewReportTest for real this time, wrong order in assertEquals
2014-02-25 21:21:08 +13:00
Stig Lindqvist
5cae6165d2
Bad test fixture that messed up postgresql tests #16
2014-02-25 21:15:41 +13:00
Stig Lindqvist
e123c1c0e7
Fixed tests for PagesDueForReviewReport
2014-02-25 20:43:46 +13:00
Stig Lindqvist
3017712dfb
BUG Cant get owner names from a page that is disabled
2014-02-25 20:34:42 +13:00
Stig Lindqvist
6b337496cf
NEW Send one notification email per author #7
2014-02-25 15:54:27 +13:00
Stig Lindqvist
e539ddc165
BUG Inherited settings doesn't trigger the mark as review button to show up
2014-02-25 12:10:39 +13:00
Stig Lindqvist
c021af834b
Group tests together in the same test class #3
2014-02-25 00:51:36 +13:00
Stig Lindqvist
de4fac0541
AdvanceReviewDate now can use inherited settings #3
2014-02-25 00:46:50 +13:00
Stig Lindqvist
bfbc53c080
More coverage
2014-02-24 22:14:26 +13:00
Stig Lindqvist
32378bb269
Refactorings
2014-02-24 21:17:09 +13:00
Stig Lindqvist
638d2fc331
Refactorings
2014-02-24 21:10:10 +13:00
Stig Lindqvist
ee7feeb130
When changing parents content review setting update the inherited childrens settings as well
2014-02-24 20:19:44 +13:00
Stig Lindqvist
d340004933
Tests and fixes for inherited settings
2014-02-24 13:38:16 +13:00
Stig Lindqvist
57f08027c7
Fix tests after moving the settings
2014-02-19 15:29:21 +13:00
Stig Lindqvist
f806987ba7
Improving the code coverage
2014-02-19 09:51:54 +13:00
Stig Lindqvist
7a843e222f
Improving test coverage
2014-02-18 15:39:13 +13:00
Stig Lindqvist
ae440666a0
Adding content reviewed actions to a sitetree
2014-02-14 14:49:43 +13:00
Stig Lindqvist
131d643a8c
Allow users and/or groups to be content owners
2014-02-13 16:35:13 +13:00
Stig Lindqvist
d28a0eefa0
Coding style guidelines
2014-02-13 14:10:09 +13:00
