Merge pull request #181 from creative-commoners/pulls/5/remove-legacy-upgrader

MNT Remove legacy upgrader config

.upgrade.yml

@@ -1,18 +0,0 @@
-mappings:
-  ContentReviewCompatability: SilverStripe\ContentReview\Compatibility\ContentReviewCompatability
-  ContentReviewCMSExtension: SilverStripe\ContentReview\Extensions\ContentReviewCMSExtension
-  ContentReviewDefaultSettings: SilverStripe\ContentReview\Extensions\ContentReviewDefaultSettings
-  ContentReviewOwner: SilverStripe\ContentReview\Extensions\ContentReviewOwner
-  SiteTreeContentReview: SilverStripe\ContentReview\Extensions\SiteTreeContentReview
-  ContentReviewNotificationJob: SilverStripe\ContentReview\Jobs\ContentReviewNotificationJob
-  ContentReviewLog: SilverStripe\ContentReview\Models\ContentReviewLog
-  PagesDueForReviewReport: SilverStripe\ContentReview\Reports\PagesDueForReviewReport
-  PagesWithoutReviewScheduleReport: SilverStripe\ContentReview\Reports\PagesWithoutReviewScheduleReport
-  ContentReviewEmails: SilverStripe\ContentReview\Tasks\ContentReviewEmails
-  ContentReviewOwnerMigrationTask: SilverStripe\ContentReview\Tasks\ContentReviewOwnerMigrationTask
-  ContentReviewBaseTest: SilverStripe\ContentReview\Tests\ContentReviewBaseTest
-  ContentReviewCMSPageEditControllerTest: SilverStripe\ContentReview\Tests\ContentReviewCMSPageEditControllerTest
-  ContentReviewNotificationTest: SilverStripe\ContentReview\Tests\ContentReviewNotificationTest
-  ContentReviewReportTest: SilverStripe\ContentReview\Tests\ContentReviewReportTest
-  ContentReviewSettingsTest: SilverStripe\ContentReview\Tests\ContentReviewSettingsTest
-  SiteTreeContentReviewTest: SilverStripe\ContentReview\Tests\SiteTreeContentReviewTest

_config/legacy.yml

@@ -1,6 +0,0 @@
----
-Name: contentreviewlegacy
----
-SilverStripe\ORM\DatabaseAdmin:
-  classname_value_remapping:
-    ContentReviewLog: SilverStripe\ContentReview\Models\ContentReviewLog

src/Extensions/SiteTreeContentReview.php

@@ -142,7 +142,6 @@ class SiteTreeContentReview extends DataExtension implements PermissionProvider
                 $groupMembers = DataObject::get(Member::class)
                     ->where("\"Group\".\"ID\" IN (" . implode(",", $groupIDs) . ")")
                     ->leftJoin("Group_Members", "\"Member\".\"ID\" = \"Group_Members\".\"MemberID\"")
-                    /** @skipUpgrade */
                     ->leftJoin('Group', "\"Group_Members\".\"GroupID\" = \"Group\".\"ID\"");
 
                 $contentReviewOwners->merge($groupMembers);