Merge pull request #256 from creative-commoners/pulls/6/phpunit11

DEP Use PHPUnit 11

tests/php/ContentReviewBaseTest.php

@@ -1,18 +0,0 @@
-<?php
-
-namespace SilverStripe\ContentReview\Tests;
-
-use SilverStripe\Dev\FunctionalTest;
-use SilverStripe\CMS\Model\SiteTree;
-
-/**
- * Extend this class when writing unit tests which are compatible with other modules.
- * All compatibility code goes here.
- */
-abstract class ContentReviewBaseTest extends FunctionalTest
-{
-    /**
-     * @var bool
-     */
-    protected $translatableEnabledBefore;
-}

tests/php/ContentReviewCMSPageEditControllerTest.php

@@ -16,8 +16,9 @@ use SilverStripe\Forms\Form;
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
 use SilverStripe\SiteConfig\SiteConfig;
+use SilverStripe\Dev\FunctionalTest;
 
-class ContentReviewCMSPageEditControllerTest extends ContentReviewBaseTest
+class ContentReviewCMSPageEditControllerTest extends FunctionalTest
 {
     /**
      * @var string

tests/php/Extensions/ContentReviewCMSExtensionTest.php

@@ -21,7 +21,7 @@ class ContentReviewCMSExtensionTest extends SapphireTest
     public function testReviewContentForm()
     {
         $mock = $this->getMockBuilder(ContentReviewCMSExtension::class)
-            ->setMethods(['getReviewContentForm'])
+            ->onlyMethods(['getReviewContentForm'])
             ->getMock();
 
         $mock->expects($this->once())->method('getReviewContentForm')->with(123)->willReturn(true);
@@ -45,7 +45,7 @@ class ContentReviewCMSExtensionTest extends SapphireTest
         $this->logOut();
 
         $mock = $this->getMockBuilder(ContentReviewCMSExtension::class)
-            ->setMethods(['findRecord'])
+            ->onlyMethods(['findRecord'])
             ->getMock();
 
         $mock->setOwner(new Controller);
@@ -62,7 +62,7 @@ class ContentReviewCMSExtensionTest extends SapphireTest
     public function testSaveReviewCallsHandler()
     {
         $mock = $this->getMockBuilder(ContentReviewCMSExtension::class)
-            ->setMethods(['findRecord', 'getReviewContentHandler'])
+            ->onlyMethods(['findRecord', 'getReviewContentHandler'])
             ->getMock();
 
         $mock->setOwner(new Controller);
@@ -71,7 +71,7 @@ class ContentReviewCMSExtensionTest extends SapphireTest
         $mock->expects($this->once())->method('findRecord')->willReturn($mockPage);
 
         $mockHandler = $this->getMockBuilder(ReviewContentHandler::class)
-            ->setMethods(['submitReview'])
+            ->onlyMethods(['submitReview'])
             ->getMock();
 
         $mockHandler->expects($this->once())

tests/php/Forms/ReviewContentHandlerTest.php

@@ -63,7 +63,7 @@ class ReviewContentHandlerTest extends SapphireTest
 
         $mock = $this->getMockBuilder(ReviewContentHandler::class)
             ->setConstructorArgs([$controller])
-            ->setMethods(['canSubmitReview'])
+            ->onlyMethods(['canSubmitReview'])
             ->getMock();
 
         $mock->expects($this->exactly(3))->method('canSubmitReview')->willReturn(true);

tests/php/SiteTreeContentReviewTest.php

@@ -18,11 +18,17 @@ use SilverStripe\Security\Member;
 use SilverStripe\SiteConfig\SiteConfig;
 use SilverStripe\Versioned\Versioned;
 use SilverStripe\ORM\ArrayList;
+use SilverStripe\Dev\FunctionalTest;
+use SilverStripe\ContentReview\Tests\SiteTreeContentReviewTestPage;
 
-class SiteTreeContentReviewTest extends ContentReviewBaseTest
+class SiteTreeContentReviewTest extends FunctionalTest
 {
     protected $usesTransactions = false;
 
+    protected static $extra_dataobjects = [
+        SiteTreeContentReviewTestPage::class,
+    ];
+
     /**
      * @var string
      */
@@ -372,14 +378,8 @@ class SiteTreeContentReviewTest extends ContentReviewBaseTest
     {
         $reviewer = $this->objFromFixture(Member::class, 'editor');
 
-        // Mock Page class with canReviewContent method to return true on first call and false on second call
-        $mock = $this->getMockBuilder(Page::class)
-            ->setMethods(['canReviewContent', 'NextReviewDate', 'OwnerUsers'])
-            ->getMock();
-        $mock->expects($this->exactly(2))->method('canReviewContent')->willReturnOnConsecutiveCalls(false, true);
-        $mock->method('NextReviewDate')->willReturn('2020-02-20 12:00:00');
-        $mock->method('OwnerUsers')->willReturn(ArrayList::create([$reviewer]));
-        $mock->ContentReviewType = 'Custom';
+        $mock = new SiteTreeContentReviewTestPage();
+        $mock->setReviewer($reviewer);
 
         /** @var SiteTreeContentReview $extension */
         $extension = Injector::inst()->get(SiteTreeContentReview::class);

tests/php/SiteTreeContentReviewTestPage.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace SilverStripe\ContentReview\Tests;
+
+use Page;
+use SilverStripe\Dev\TestOnly;
+use SilverStripe\ORM\ArrayList;
+
+/**
+ * Mock Page class with canReviewContent method to return false on first call
+ * and true on second call
+ */
+class SiteTreeContentReviewTestPage extends Page implements TestOnly
+{
+    public $ContentReviewType = 'Custom';
+
+    private $i = 0;
+
+    private $reviewer;
+
+    public function setReviewer($reviewer)
+    {
+        $this->reviewer = $reviewer;
+    }
+
+    public function canReviewContent()
+    {
+        $this->i++;
+        return $this->i === 1 ? false : true;
+    }
+
+    public function NextReviewDate()
+    {
+        return '2020-02-20 12:00:00';
+    }
+
+    public function OwnerUsers()
+    {
+        return ArrayList::create([$this->reviewer]);
+    }
+}