tonyair/silverstripe-contentreview
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-contentreview synced 2024-10-22 17:05:47 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #102 from pjayme/bugfix/ownergroups-check-before-method-call

Browse Source 
BUGFIX: Error trying to access OwnerGroups() method on boolean value
This commit is contained in:
Robbie Averill 2018-08-22 08:48:58 +12:00 committed by GitHub
commit 188f77c569
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Reports/PagesDueForReviewReport.php
View File

@ -217,11 +217,13 @@ class PagesDueForReviewReport extends Report
$records = $records->filterByCallback(function ($page) use ($currentUser) { $records = $records->filterByCallback(function ($page) use ($currentUser) {
$options = $page->getOptions(); $options = $page->getOptions();
if ($options) {
foreach ($options->ContentReviewOwners() as $owner) { foreach ($options->ContentReviewOwners() as $owner) {
if ($currentUser->ID == $owner->ID) { if ($currentUser->ID == $owner->ID) {
return true; return true;
} }
} }
}
return false; return false;
}); });

6
src/Tasks/ContentReviewEmails.php
View File

@ -68,9 +68,10 @@ class ContentReviewEmails extends BuildTask
continue; continue;
} }
$option = $page->getOptions(); $options = $page->getOptions();
foreach ($option->ContentReviewOwners() as $owner) { if ($options) {
foreach ($options->ContentReviewOwners() as $owner) {
if (!isset($overduePages[$owner->ID])) { if (!isset($overduePages[$owner->ID])) {
$overduePages[$owner->ID] = ArrayList::create(); $overduePages[$owner->ID] = ArrayList::create();
} }
@ -78,6 +79,7 @@ class ContentReviewEmails extends BuildTask
$overduePages[$owner->ID]->push($page); $overduePages[$owner->ID]->push($page);
} }
} }
}
return $overduePages; return $overduePages;
} }