tonyair/silverstripe-contentreview
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-contentreview synced 2024-10-22 17:05:47 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #233 from creative-commoners/pulls/6/protect-hooks

Browse Source 
API Set extension hook implementation visibility to protected
This commit is contained in:
Guy Sartorelli 2024-05-21 16:03:36 +12:00 committed by GitHub
commit 078c91560f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Extensions/ContentReviewDefaultSettings.php
View File

@ -110,7 +110,7 @@ class ContentReviewDefaultSettings extends DataExtension
/** /**
* @param FieldList $fields * @param FieldList $fields
*/ */
public function updateCMSFields(FieldList $fields) protected function updateCMSFields(FieldList $fields)
{ {
$helpText = LiteralField::create( $helpText = LiteralField::create(
'ContentReviewHelp', 'ContentReviewHelp',

2
src/Extensions/ContentReviewLeftAndMainExtension.php
View File

@ -15,7 +15,7 @@ class ContentReviewLeftAndMainExtension extends LeftAndMainExtension
* *
* @param array &$clientConfig * @param array &$clientConfig
*/ */
public function updateClientConfig(&$clientConfig) protected function updateClientConfig(&$clientConfig)
{ {
$clientConfig['form']['ReviewContentForm'] = [ $clientConfig['form']['ReviewContentForm'] = [
'schemaUrl' => $this->owner->Link('schema/ReviewContentForm') 'schemaUrl' => $this->owner->Link('schema/ReviewContentForm')

2
src/Extensions/ContentReviewOwner.php
View File

@ -23,7 +23,7 @@ class ContentReviewOwner extends DataExtension
"SiteTreeContentReview" => SiteTree::class, "SiteTreeContentReview" => SiteTree::class,
]; ];
public function updateCMSFields(FieldList $fields) protected function updateCMSFields(FieldList $fields)
{ {
// Remove automatically scaffolded GridField in Member CMS fields // Remove automatically scaffolded GridField in Member CMS fields
$fields->removeByName('SiteTreeContentReview'); $fields->removeByName('SiteTreeContentReview');

6
src/Extensions/SiteTreeContentReview.php
View File

@ -161,7 +161,7 @@ class SiteTreeContentReview extends DataExtension implements PermissionProvider
/** /**
* @param FieldList $actions * @param FieldList $actions
*/ */
public function updateCMSActions(FieldList $actions) protected function updateCMSActions(FieldList $actions)
{ {
if (!$this->canBeReviewedBy(Security::getCurrentUser())) { if (!$this->canBeReviewedBy(Security::getCurrentUser())) {
return; return;
@ -326,7 +326,7 @@ class SiteTreeContentReview extends DataExtension implements PermissionProvider
/** /**
* @param FieldList $fields * @param FieldList $fields
*/ */
public function updateSettingsFields(FieldList $fields) protected function updateSettingsFields(FieldList $fields)
{ {
if ($this->owner->hasMethod('displayContentReview') && !$this->owner->displayContentReview()) { if ($this->owner->hasMethod('displayContentReview') && !$this->owner->displayContentReview()) {
return; return;
@ -564,7 +564,7 @@ class SiteTreeContentReview extends DataExtension implements PermissionProvider
/** /**
* Set the review data from the review period, if set. * Set the review data from the review period, if set.
*/ */
public function onBeforeWrite() protected function onBeforeWrite()
{ {
// Only update if DB fields have been changed // Only update if DB fields have been changed
$changedFields = $this->owner->getChangedFields(true, 2); $changedFields = $this->owner->getChangedFields(true, 2);