mirror of
https://github.com/silverstripe/silverstripe-cms
synced 2024-06-25 05:59:37 +02:00
599e198e89
Hello @robbieaverill, please check my assumption...it's been a long time since I have last used SS (v3.2 was my last, if i remember correctly)
in the following lines 438:
```php
if (isset($this->templates[$action]) && $this->templates[$action]
|| (isset($this->templates['index']) && $this->templates['index'])
|| $this->template
) {
return parent::getViewer($action);
}
```
it looks like the 1st two (same-line) condition should be wrapped inside `()` while checking for a non-index action template .... if not just kill this PR at once. :-)
if the answer is yes then we can just use `!empty(...)` which is the same as 'isset(...) + truthy check'
kind regards,
maks
|
||
|---|---|---|
| .. | ||
| BatchActions | ||
| Controllers | ||
| Forms | ||
| Model | ||
| Reports | ||
| Search | ||
| Tasks | ||