Compare commits

...

3 Commits

Author SHA1 Message Date
Guy Sartorelli
3d006a6958
Merge dc43d36d62 into 6194844f61 2024-09-27 02:41:08 +00:00
Guy Sartorelli
dc43d36d62
ENH Improve type safety to support refactored template layer 2024-09-27 14:41:02 +12:00
Guy Sartorelli
6194844f61
ENH Use standardised BackURL instead of non-standard returnURL (#2999) 2024-09-27 10:00:33 +12:00
3 changed files with 6 additions and 6 deletions

View File

@ -60,7 +60,7 @@ class ModelAsController extends Controller implements NestedController
Director::absoluteBaseURL(),
'dev/build',
'?' . http_build_query([
'returnURL' => isset($_GET['url']) ? $_GET['url'] : null,
'BackURL' => isset($_GET['url']) ? $_GET['url'] : null,
])
));
}
@ -81,7 +81,7 @@ class ModelAsController extends Controller implements NestedController
// If the database has not yet been created, redirect to the build page.
if (!DB::is_active() || !ClassInfo::hasTable('SiteTree')) {
$this->getResponse()->redirect(Controller::join_links(Director::absoluteBaseURL(), 'dev/build?returnURL=' . (isset($_GET['url']) ? urlencode($_GET['url']) : null)));
$this->getResponse()->redirect(Controller::join_links(Director::absoluteBaseURL(), 'dev/build?BackURL=' . (isset($_GET['url']) ? urlencode($_GET['url']) : null)));
$this->popCurrent();
return $this->getResponse();

View File

@ -78,7 +78,7 @@ class RootURLController extends Controller implements Resettable
Director::absoluteBaseURL(),
'dev/build',
'?' . http_build_query([
'returnURL' => isset($_GET['url']) ? $_GET['url'] : null,
'BackURL' => isset($_GET['url']) ? $_GET['url'] : null,
])
));
}
@ -91,7 +91,7 @@ class RootURLController extends Controller implements Resettable
if (!$this->getResponse()->isFinished()) {
if (!DB::is_active() || !ClassInfo::hasTable('SiteTree')) {
$this->getResponse()->redirect(Director::absoluteBaseURL() . 'dev/build?returnURL=' . (isset($_GET['url']) ? urlencode($_GET['url']) : null));
$this->getResponse()->redirect(Director::absoluteBaseURL() . 'dev/build?BackURL=' . (isset($_GET['url']) ? urlencode($_GET['url']) : null));
return $this->getResponse();
}

View File

@ -1454,7 +1454,7 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
$tags['title'] = [
'tag' => 'title',
'content' => $this->obj('Title')->forTemplate()
'content' => $this->obj('Title')?->forTemplate()
];
$generator = $this->getGenerator();
@ -1601,7 +1601,7 @@ class SiteTree extends DataObject implements PermissionProvider, i18nEntityProvi
$tagString = implode("\n", $tags);
if ($this->ExtraMeta) {
$tagString .= $this->obj('ExtraMeta')->forTemplate();
$tagString .= $this->obj('ExtraMeta')?->forTemplate();
}
$this->extend('updateMetaTags', $tagString);