Commit Graph

208 Commits

Author SHA1 Message Date
Ingo Schommer
fe543edcd6 BUGFIX: Ticket #4805
added a canCreateTopLevel() if there is no parent object in CMSMain.php 
added testCreationOfTopLevelPage toCMSMainTest.php
added the nessessary 'database entries' in the CMSMainTest.yml (from r98001)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102749 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 01:36:42 +00:00
Ingo Schommer
3b50f8d3f3 ENHANCEMENT Changed menu title from "Site Content" to "Pages" to be consistent with other menu labels
ENHANCEMENT Changed tree root node in CMS to get title from SiteConfig rather than defaulting to "Site Content"
ENHANCEMENT Changed tree panel headline in CMS from "Site Content and Structure" to "Page Tree" to stay consistent with new CMS menu title (from r97597)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 22:19:49 +00:00
Ingo Schommer
2e1b39dfc4 MINOR Backwards compat fix for sprintf() call in CMSMain->providePermissions() (#4764) (from r97485)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 20:37:34 +00:00
Ingo Schommer
af2f81e37a BUGFIX Setting 'Locale' as HiddenField in CMSMain->getEditForm() to support translatable SiteConfig records (see r97370, #4770) (from r97472)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102715 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 20:37:16 +00:00
Ingo Schommer
ffbcc5d778 MINOR Reverted 'single instance only' feature from r79868, delayed until later release (see #4277) (from r97182)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 07:01:56 +00:00
Ingo Schommer
bce6ff833b MINOR Removed 'print' button from CMSMain->getEditForm() for display of older versions (see #4745) (from r97178)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102708 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 06:59:47 +00:00
Ingo Schommer
184289b3d9 BUGFIX: Use canDeleteFromLive instead of canPublish for checking delete from live action (from r93316) (from r96817)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102679 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:56:00 +00:00
Ingo Schommer
fd2037f603 BUGFIX: Use doDeleteFromLive when deleting pages from live, so that onBeforeUnpublish and onAfterUnpublish are called. (from r91381) (from r96811)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102674 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:52:07 +00:00
Ingo Schommer
1e972ed695 MINOR add a hidden field to attach the subsite ID, rather than relying on the session (from r91014) (from r96808)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102672 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:51:24 +00:00
Ingo Schommer
4078c31f66 MINOR: Fixed notice-level error in rollback. (from r90260) (from r96804)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102667 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:28:36 +00:00
Ingo Schommer
e98eb98238 BUGFIX: Don't set the Owner by default on new records. (from r89910) (from r96796)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102659 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:26:19 +00:00
Ingo Schommer
b7a1e438f7 BUGFIX: Fix changing the URLSegment on a page making the Draft Site link
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@102475 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 09:41:45 +00:00
Ingo Schommer
51a330f594 BUGFIX Removed calls to Translatable::is_enabled() since it's deprecated, replaced with Object::has_extension('SiteTree', 'Translatable') instead (from r93676)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@93953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-30 01:04:56 +00:00
Ingo Schommer
b29d887cc2 MINOR l10n in CMSMain.php, CMSMain.js and CMSSiteTreeFilter.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92941 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-22 08:45:59 +00:00
Ingo Schommer
a5070b858a API CHANGE Removed CMSSiteTreeFilter->showInList(), using custom logic in CMSMain->SearchTreeForm() instead
API CHANGE Returning arrays instead of Query resource from CMSSiteTreeFilter->pagesIncluded()
MINOR Removed unused LeftAndMain->getMarkingFilter() and CMSMainMarkingFilter, now handled by CMSSiteTreeFilter and CMSMain->SearchTreeForm()
ENHANCEMENT Moved 'page tree filter' dropdown logic into an additional option for CMSMain->SearchTreeForm() (originally implemented in r83674)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-22 08:23:12 +00:00
Ingo Schommer
683dfa9426 MINOR Styling of side reports and tree area in CMS
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:21:08 +00:00
Ingo Schommer
9c3ecea1e7 ENHANCEMENT Unifying tree logic in most LeftAndMain subclasses: CMSMain, SecurityAdmin, AssetAdmin. Using a common LeftAndMainMarkingFilter. Allowing for custom node counts in SecurityAdmin and AssetAdmin.
API CHANGE Renamed CMSMain->getfilteredsubtree() to doSearchTree()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:21:00 +00:00
Ingo Schommer
f793ffd368 ENHANCEMENT SideReportsHandler class for easier handling and templating of "side reprts" in the CMS interface
API CHANGE Removed CMSMain->ReportFormParameters()/ReportForm()/sidereport(), replaced with new SideReportsHandler class

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:54 +00:00
Ingo Schommer
2d82a2ff35 MINOR Syntax error and documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:36 +00:00
Ingo Schommer
45f87288fc API CHANGE Moved CMSMain/AssetAdmin/SecurityAdmin implementations for getEditForm() and save() to a common parent: LeftAndMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:26 +00:00
Ingo Schommer
98ce1b1f07 MINOR Moved batch actions code from AssetAdmin/CMSMain to a common LeftAndMain parent (which is now reused by SecurityAdmin as well)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:20:21 +00:00
Ingo Schommer
0c52d36846 BUGFIX Fixed undefined variable in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:49 +00:00
Ingo Schommer
343044e89c ENHANCEMENT Using built-in TableListField javascript deletion for AssetTableField
ENHANCEMENT Less template overloading in AssetTableField.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:47 +00:00
Ingo Schommer
2e7f100a1c MINOR Moved LeftAndMain.BatchActions.js to LeftAndMain, its used in AssetAdmin as well
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:20 +00:00
Ingo Schommer
e47ce88853 ENHANCEMENT Making CMSBatchActionHandler specific to record class, in order to have different batch actions for AssetAdmin (removing folders). Added CMSBatchActionHandler->batchActions() and changed internal representation of batch actions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92801 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:19:02 +00:00
Ingo Schommer
58cd7beb33 MINOR Renamed CMSMain->addpage() to CMSMain->doAdd()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92800 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:18:59 +00:00
Ingo Schommer
34f8f9eaf3 MINOR Moved batch actions javascript from CMSMain.BatchAction.js to LeftAndMain.BatchActions.js to make it reuseable in AssetAdmin
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92798 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:18:55 +00:00
Ingo Schommer
b9bfcc99b5 API CHANGE Renamed CMSMain->AddPageOptionsForm() to AddForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92797 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:18:51 +00:00
Ingo Schommer
23bac6e84f API CHANGE LeftAndMain->EditForm() returns EmptyForm() by default, as not all subclasses might want to implement the previously used getEditForm() method (e.g. ModelAdmin, which has its own sub-controllers to handle requests). Added specialized EditForm() overrides to AssetAdmin and CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:17:16 +00:00
Ingo Schommer
e22fdb94ca BUGFIX Defaulting to current page ID in CMSMain->EditForm()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92757 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:17:11 +00:00
Ingo Schommer
94eada294e API CHANGE Removed unnecessary CMSMain->getpagecount() method
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92751 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:57 +00:00
Ingo Schommer
44e3966d96 ENHANCEMENT Removed manual SiteTree->Status setting in LeftAndMain controllers, use specific getters like SiteTree->IsAddedToStage for this purpose
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92745 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:42 +00:00
Ingo Schommer
64e042a2a3 ENHANCEMENT Removed unused LeftAndMain->DeleteItemsForm
ENHANCEMENT Moved LeftAndMain->deleteitems() into SecurityAdmin, its the only place where its not replaced by CMSBatchAction yet

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92743 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:38 +00:00
Ingo Schommer
420d0a5c57 MINOR Removed unused LeftAndMain->PublishItemsForm(), has been replaced by CMSBatchAction a while ago
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92742 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:35 +00:00
Ingo Schommer
cb1895866a ENHANCEMENT Refactored versions panel in CMS: Removed "compare mode" checkbox in UI, and replaced with explicit checkboxes and a "compare versions" button. Added manual "refresh" button. Replaced custom markup with a form generated through CMSMain->VersionsForm(), and adjusted markup in CMSMain_versions.ss accordingly
API CHANGE Removed CMSMain->sendFormToBrowser(), replaced with custom code

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:09 +00:00
Ingo Schommer
c50e2fce6b MINOR Moved form related javascript from CMSMain.js to new CMSMain.EditForm.js
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92729 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:03 +00:00
Ingo Schommer
01d06dd47e API CHANGE Replaced CMSMain->LangSelector() with CMSMain->LangForm() to provide more accessible backend and properly wrap existing <select> tag in a form
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92728 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:16:00 +00:00
Ingo Schommer
2796a37a02 API CHANGE Removed SideReport javascript class, replaced with concrete implementation in CMSMain.js
ENHANCEMENT Using full form for 'site reports' panel in CMSMain->ReportForm(). Removed CMSMain->ReportSelector()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92727 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:55 +00:00
Ingo Schommer
1760759992 MINOR Moved LeftAndMain_left.js to LeftAndMain.Tree.js
MINOR Moved CMSMain_left.js to CMSMain.Tree.js

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:51 +00:00
Ingo Schommer
49ff1648bd MINOR Fixed parameters in CMSMain->getfilteredsubtree()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:43 +00:00
Ingo Schommer
44e16b9620 API CHANGE Removed CMSBatchAction->getDoingText(), is now using button loading indicators in the UI
API CHANGE Removed LeftAndMain->BatchActionList(), no longer necessary as we're creating the batch actions form in the same class
ENHANCEMENT Changed CMSBatchAction logic to return JSON status changes rather than eval'ed JavaScript via FormResponse
ENHANCEMENT Ported batchactions in CMSMain_left.js to concrete javascript, and moved to new CMSMain.BatchActions.js file
ENHANCEMENT Using native CMSMain->BatchActionsForm() to render form instead of custom template markup in CMSMain_TreeTools.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92722 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:40 +00:00
Ingo Schommer
9e88dbb8c5 MINOR Adding css classes to CMSMain->AddPageOptionsForm
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92711 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:16 +00:00
Ingo Schommer
dc4375a383 API CHANGE Removed LeftAndMain->EditForm(), please use getEditForm() instead
API CHANGE Returning LeftAndMain->EmptyForm() as a welcome/placeholder message from LeftAndMain->getEditForm() if no record is found. Removed this placeholder from LeftAndMain_right.ss
ENHANCEMENT Allowing optional $id parameter in LeftAndMain->getEditForm() (and subclasses)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:13 +00:00
Ingo Schommer
e30f92a2f8 API CHANGE Returning empty form from getEditForm() method in CMSMain, AssetAdmin, SecurityAdmin to avoid an <% if %> condition in the template. The previous placeholder text is now always stored alongside the form template. This also allows for easier class overloading with different URLs, as the form action is no longer hardcoded in the template placeholder form.
BUGFIX Adjusted AssetAdmin_left.ss, CommentAdmin_left.ss
MINOR Removed CommentAdmin_right.ss, SecurityAdmin_right.ss - inherits a more generic LeftAndMain_right.ss instead
MINOR Merged CommentAdmin_SiteTree.ss template back into CommentAdmin_left.ss

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:15:00 +00:00
Ingo Schommer
40e3f96ce8 MINOR PHP Notice in CMSMain
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92704 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:56 +00:00
Ingo Schommer
febe9f6e8b MINOR Removed unnecessary CMSMain_right.js javascript, was only used for form changetracking which has changed its API since
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 03:14:45 +00:00
Ingo Schommer
c2d24f9022 FEATURE Changed CMSMain and LeftAndMain form submissions to return raw HTML instead of using FormResponse logic and evaluated javascript. This allows a more customizeable UI layer that is decoupled from the serverside logic. Any state changes should be propagated through the form itself.
ENHANCEMENT Using new 'X-STATUS' HTTP response header for CMS form responses, as it is more robust for submitting variable length strings than the original 'Status' header. The status is evaluated in LeftAndMain.EditForm.js
API CHANGE Removed CMSMain->tellBrowserAboutPublicationChange(), LeftAndMain->returnItemToUser(), LeftAndMain->getActionUpdateJS(), LeftAndMain->addTreeNodeJS(), LeftAndMain->deleteTreeNodeJS(). Use javascript to respond to state changes
API CHANGE Removed CMSForm and CMSRightForm javascript classes, superseded by LeftAndMain.EditForm.js
ENHANCEMENT Removed custom change detection in LeftAndMain->save(), this should be handled by DataObject->write()
ENHANCEMENT Removed switch in LeftAndMain->save() which doesnt process saving if the record hasn't been altered, to simplify the saving logic
ENHANCEMENT Removed custom add/remove tree node logic in LeftAndMain->save() which was retrieving state from DataObjectLog. This was never actively used, and should be handled by custom clientside logic.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92674 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:12 +00:00
Ingo Schommer
b99ee16d88 ENHANCEMENT Removed CMSMain->jsDeclaration(), it was replicating functionality already present in Convert::raw2js()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92671 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:39:04 +00:00
Ingo Schommer
0b9f4ab533 MINOR Adjusted to SiteTree->getTreeTitle() api change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92669 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:59 +00:00
Ingo Schommer
87a6e331e9 ENHANCEMENT Disabling validator in CMSMain->getCMSFields() unless its explicitly set through SiteTree->getCMSValidator(). We don't fully support validation in the CMS (yet), and it causes unnecessary bloat in the document body for now.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/cms/trunk@92660 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:38:39 +00:00