When editing a page an author may insert anchors into their content (via
TinyMCE), and wish to link to those anchors from another point in that
page. E.g. creating a table of contents, a "jump to top" link at the
base of the content, etc.
Previously this required the page to first be saved as a draft, then
reloaded before the anchors would show in the list to link to. Now they
are dynamically pulled from the content entered for a more fluid editing
experience.
To reproduce this issue open a page, add an anchor, save the page, go to link to newly created anchor on the same page.
Incorrect result will be the new anchor does not appear. This patch ensures that the page anchors are reloaded.
* Various refactoring to support viewing list view in context menu and suppressed tree node
* Bugfixes per Maxime review
* Fix URL param collision
* Fix show in list on detail view
* Remove AJAX for show in list. Use hard refresh to keep URL state
Squashed commit of the following:
commit 6ee00358f70e26ef5faf622b8f23fc4419698ed5
Author: Maxime Rainville <maxime@silverstripe.com>
Date: Wed Jul 11 13:22:07 2018 +1200
Remove debug statement.
commit 8e80300244a19e84d638ffd151b236b846c35b77
Author: Luke Edwards <luke@silverstripe.com>
Date: Wed Jul 11 10:55:04 2018 +1200
Only remove actions for readonly rather than only display link
commit 1d3693432bb1ca403d3eefc648cfddb8372b82bd
Author: Luke Edwards <luke@silverstripe.com>
Date: Wed Jul 11 09:12:21 2018 +1200
Stop button wrapping when 'Cancel' is longer in another language
commit 5495992b22a0546aaa87e5ea1b2fa9c79f6e119d
Author: Luke Edwards <luke@silverstripe.com>
Date: Tue Jul 10 16:02:27 2018 +1200
Use link as the readonly representation of the URLSegment
commit 5737e152424281dbea480872900d735cc43f5fd3
Author: Luke Edwards <luke@silverstripe.com>
Date: Mon Jun 18 11:07:34 2018 +1200
Improve readonly styling of URLSegement field
commit 272da9361452843fbb368bfc67e13e6d9540faf2
Author: Luke Edwards <luke@silverstripe.com>
Date: Mon Jun 18 10:18:33 2018 +1200
Use input-addon style for URLSegment field
* NEW Add revert mutation and refactor injector transformations
Removing the existing HOC component and just using Injector transformations to apply the GraphQL query and mutation
* Refetch versions after performing the revert mutation
* WIP Provide additional context
There exists functionality in the CMS to print various pages via the
`printable` action on `SilverStripe\Admin\LeftAndMain` - however this
appears to be no longer activated by default. The accompanying legacy
(entwine) javascript dynamically accesses this action by chaning the
HTML form `action` attribute whenever a `FormAction` named `print` is
clicked on an EditForm. Unfortunately this is almost all of them - which
blocks the correct functionality of
`SilverStripe\Forms\GridField\GridFieldPrintButton`
which provides it's own action handling via proper SilverStripe routing.
Since print buttons are no longer a part of the various parts of the CMS
any longer, it appears easiest to simply remove this legacy javascript.
This doesn’t have much impact on resulting JS size, but it will
hopefully make merge conflicts much less frequent.
The CSS growth is a little higher (6.5% increase in size) but is not
material.
If this materially reduces the number of merge conflicts we have, by
letting the git merge tools resolve some dist file mergers, I think it
would be worth it.
See https://github.com/silverstripe/silverstripe-framework/pull/6051
This is now handled through one combined bundle
which is included through LeftAndMain.php (in framework module)
Rename bundle-legacy.js to bundle.js: It'll contain more than legacy stuff eventually
Remove leftover dist artefacts: These weren't part of the webpack build any more
Building SilverStripeNavigator separately (and rename bundle)