Commit Graph

257 Commits

Author SHA1 Message Date
Guy Sartorelli
ca837d6ccd
Merge branch '4' into 5.0 2023-04-27 14:44:59 +12:00
Guy Sartorelli
cd7fe60a33
Merge branch '4.12' into 4.13 2023-04-24 11:49:18 +12:00
Dylan Wagstaff
e20036482b FIX undefined index error in CMS
With the CMS 4.12 update functionality was altered to utilise an
Extension to obtain the CMS Edit link for a page, rather than having
SiteTree do it internally. Unfortunately the default return case for
`extend` (see Extensible) is an _empty_ array. This leave code
potentially referencing an array offset that doesn't exist ([0]). PHP 8
is less forgiving that it's predecessors on this kind of behaviour. We
should check that the responses from extensions exist before trying to
reference them.
2023-03-28 18:58:55 +13:00
Maxime Rainville
081eea42c5
Merge pull request #2824 from creative-commoners/pulls/5/remove-legacy-upgrader
MNT Remove legacy upgrader config
2023-01-23 10:36:04 +13:00
Steve Boyd
30685c9227 MNT Remove legacy upgrader config 2023-01-20 17:13:11 +13:00
Guy Sartorelli
37af732dbf
Merge pull request #2771 from xini/fix-5-remove-trailing-slash-from-sitetree-links
SS5: Remove trailing slash from SiteTree links if no action present
2023-01-20 15:46:39 +13:00
Florian Thoma
18cb6d499d
API Normalise trailing slashes in links 2023-01-20 15:08:37 +13:00
Maxime Rainville
69fabe9a34
Merge pull request #2818 from creative-commoners/pulls/5/remove-legacy-tasks
API Remove legacy tasks
2023-01-18 14:22:01 +13:00
Maxime Rainville
50cefa6d14 Merge branch '4' into 5 2023-01-17 22:35:51 +13:00
Steve Boyd
1bd578fc96 API Remove legacy tasks 2023-01-17 12:31:51 +13:00
Guy Sartorelli
d90f27da64
Merge branch '4.12' into 4 2022-12-19 01:42:17 +00:00
Steve Boyd
605daf5026 FIX Cast absoluteUrl() argument to string 2022-12-09 10:02:43 +13:00
Sabina Talipova
0e5428b78b
API Remove deprecated code (#2800) 2022-12-08 10:44:36 +13:00
Steve Boyd
20467b3846 API Stop using deprecated API 2022-11-24 13:03:26 +13:00
Guy Sartorelli
911a71d6f6
Merge branch '4' into '5' 2022-11-21 18:07:57 +13:00
Guy Sartorelli
003f9ba750
Revert "Merge branch '4' into 5"
This reverts commit 2d10a624b3, reversing
changes made to af1a482d20.
2022-11-21 17:11:42 +13:00
Sabina Talipova
2d10a624b3 Merge branch '4' into 5 2022-11-21 16:59:42 +13:00
Steve Boyd
4c3bd3713d Merge branch '4.11' into 4.12-release 2022-11-21 13:53:57 +13:00
Steve Boyd
e64bfdb394 API Stop using deprecated API 2022-11-16 15:39:13 +13:00
Steve Boyd
55b17c920c API Update deprecations 2022-10-18 15:23:59 +13:00
Steve Boyd
ea92339d8d ENH Update deprecation messages 2022-10-18 15:17:19 +13:00
Guy Sartorelli
9b64c7de24
Merge branch '4' into 5 2022-10-13 11:18:14 +13:00
Steve Boyd
d162fab123
[CVE-2022-37421] Sanitise ExtraMeta field for XSS 2022-10-03 12:55:04 +13:00
Guy Sartorelli
1f360c9c26
ENH Use the new CMSEditLinkExtension on SiteTree (#2778) 2022-09-30 15:10:49 +13:00
Florian Thoma
1711c0c88e
API Move updateRelativeLink hook after concatination (#2770)
* move updateRelativeLink hook after concatination to make it actually updatable

* keep existing parameters the same

* revert to link parameter be first

* update updateRelativeLink method signature in SiteTreeExtension

* don't pass old parameters by reference
2022-08-31 12:33:05 +12:00
Mike Cochrane
b46876b8a8
FIX Don't offer to restore to root if can_be_root is false 2022-08-25 14:18:50 +12:00
Guy Sartorelli
bb158e4f2e
Merge pull request #2730 from creative-commoners/pulls/4/php81
ENH PHP 8.1 compatibility
2022-04-22 16:18:11 +12:00
Guy Sartorelli
5840285d43
Merge pull request #2488 from andrewandante/FEAT/ground_control_to_pager_tom
FEATURE add config var for namespace mapping page->control
2022-04-14 16:02:20 +12:00
Steve Boyd
1b0b2154b4 ENH PHP 8.1 compatibility 2022-04-13 17:07:59 +12:00
Guy Sartorelli
13c1ae487f
Merge pull request #2731 from creative-commoners/pulls/4/p81fix
ENH Various fixes for PHP 8.1 compatibility
2022-04-13 16:10:56 +12:00
Andrew Aitken-Fincham
863ed24920 add config var for namespace mapping page->control, add test to confirm 2022-04-13 12:05:13 +12:00
Will Rossiter
ee69d75904
NEW add ability to redirect to a file on the website 2022-04-12 12:42:58 +12:00
Steve Boyd
6bea5778d7 ENH Various fixes for PHP 8.1 compatibility 2022-04-08 12:38:38 +12:00
Steve Boyd
3b62336180
NEW Include version number in meta generator tag (#2721) 2022-03-09 14:48:02 +13:00
Guy Sartorelli
b4e3a08b8a ENH Prefer dependency injection for GridFieldComponents
GridFieldComponents packaged with silverstripe/framework are injectable as of 4.11.0
Explicitly invoking the injector here instead of using `create()` allows backwards compatability with framework < 4.11.0 while ensuring dependency injection is still used from 4.11.0 onwards.
2022-02-12 18:48:17 +13:00
Steve Boyd
6ab92e8f74 Merge branch '4.10' into 4 2022-02-01 13:58:32 +13:00
Steve Boyd
101b17f16e Merge branch '4.9' into 4.10 2022-02-01 13:58:00 +13:00
Steve Boyd
ab22108c85 Merge branch '4.10' into 4 2022-01-27 09:43:54 +13:00
Florian Thoma
b539924550 FIX SiteTree visibility field name 2022-01-25 11:49:11 +11:00
Sergey Shevchenko
0db24fc038
FIX SiteTree::getCMSActions unpublish action (#2703)
* TEST SiteTree::getCMSAction produces valid actions

* FIX Fix invalid SiteTree unpublish action declaration

* refactor: moved new functions to conform with existing naming conventions

see https://github.com/silverstripe/silverstripe-cms/pull/2703#discussion_r789208512
2022-01-21 13:27:02 +13:00
Nicolaas / Sunn Side Up
1338538cb9
ENH: better coding standards (#2710) 2022-01-17 12:29:25 +13:00
Steve Boyd
96fdf6dc72 Merge branch '4.9' into 4 2021-11-18 17:07:02 +13:00
Steve Boyd
c754486693
Merge pull request #2685 from GuySartorelli/patch-1
FIX: Treat absolute links in a consistent manner in get_by_link.
2021-11-15 15:10:58 +13:00
Florian Thoma
480baa6ef8
FIX Use correct canonical tag on VirtualPage (#2688) 2021-11-04 14:59:14 +13:00
kevin-hine-innis
bcbeb6d626
FIX SiteTreeLinkTracking_Parser should use the getAnchorsOnPage (#2697)
Currently, the SiteTreeLinkTracking_Parser only checks the page's content for anchors.
As a result, any anchors that have been added or modified by the updateAnchorsOnPage extension in the getAnchorsOnPage method are marked ss-broken.

This change updates SiteTreeLinkTracking_Parser to get the anchors from the getAnchorsOnPage function on SiteTree. This will allow for more consistent RegEx matching and allow the updateAnchorsOnPage extension to be used when checking for broken links.
2021-11-04 09:31:34 +13:00
Adrian Humphreys
ecd9759f83
FIX Remove unused code (#2693) 2021-10-19 12:30:00 +13:00
kevin-hine-innis
2bf691f548
FIX ensure updateAnchorsOnPage extension is called (#2686)
Currently, if there are no anchors found in the page content, the updateAnchorsOnPage extension is not called.
This change will call the updateAnchorsOnPage extension regardless of the page content.
2021-09-28 12:36:37 -07:00
GuySartorelli
734eb3921f
FIX: Treat absolute links in a consistent manner in get_by_link.
Fixes #2580 

The call to `Director::makeRelative` transforms absolute links into relative links. Previously, this meant that you could pass in "https://example.co.nz/about-us" or "about-us" and get the same result, but passing in "https://example.co.nz/" and "/"  would give _different_ results.
This commit performs the transformation to a relative link _before_ checking if the path should be for the home page, which leads to more consistent results.
2021-09-21 17:09:48 +12:00
Nicolaas
10e2c1f271
PATCH: docblock for return value fixed for get_by_link 2021-07-17 11:39:18 +12:00
Nic Horstmeier
85c3b1096b
UPDATE generate canonical via MetaComponents
This replaces using the `MetaTags` method as replacing or removing a canonical requires string manipulation vs unsetting an array key, and is preferred.
2021-04-05 19:52:35 -05:00