Commit Graph

7 Commits

Author SHA1 Message Date
Ingo Schommer
ec66912bc0 Use sass-lint
See https://github.com/silverstripe/silverstripe-framework/pull/6016
2016-09-27 17:10:47 +13:00
Ingo Schommer
db42ab772f Adding ESLint
Not much too lint yet in terms of new code, but it's consistent with framework and asset-admin modules
2016-04-08 15:08:08 +12:00
Ingo Schommer
925bdde0a5 Added "npm run lock" command 2016-04-08 14:56:01 +12:00
Ingo Schommer
23292e22b6 Updated babel dependency 2016-04-08 14:31:48 +12:00
Ingo Schommer
c4a9720730 Fix IE support by using babelify transforms 2016-04-06 09:50:00 +12:00
Ingo Schommer
abe565eb01 JS build tooling fixes
- Relaxed NodeJS dependency to 4.x

- Switch to NPM "dependencies" (rather than dev)
Provides consistency with framework, where these had previously
been broken out between "dependencies" and "devDependencies", which in turn caused issues with "npm shrinkwrap"

- Add npm-shrinkwrap.json: Consistent with framework approach
Using uber's wrapper library since it prevents npm shrinkwrap from failing on file generation,
as well as actually suceeding with an "npm install" once the file is present.

- Don't add comments to dist files via babelify
We've had some issues with different dependencies causing different results based on the environment,
which in turn causes unnecessary diffs - making our work harder to review.
Comments can be read through the ES6 source files, and through source maps when
generated through `npm run build --development`

- Make JS build tooling and naming consistent with framework
2016-03-28 22:22:21 +13:00
Ingo Schommer
ee3158183f "npm run lock" command
Uses https://github.com/uber/npm-shrinkwrap instead of the built-in "npm shrinkwrap" since it works more reliably.
Specifically, "npm install" doesn't fail depending on node_modules/ being installed in the local cache or not.
It also makes npm-shrinkwrap.json easier to diff by more consistently ordering its output between runs.

If you need any convincing that this is a problem, look at the over 400 issues related to "shrinkwrap"
in https://github.com/npm/npm/search?q=shrinkwrap&type=Issues&utf8=%E2%9C%93
2016-03-28 13:45:03 +13:00